Skip to content

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jul 17, 2025

PT030 pytest.warns(UserWarning) is too broad, set the match parameter or use a more specific warning

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 17, 2025
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the PT030 branch 10 times, most recently from 1a78087 to 38a6b9b Compare July 17, 2025 23:32
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review July 17, 2025 23:39
g5 = g3.create_group("qux")
g5.create_array("baz", shape=(100,), chunks=(10,), dtype="float64")
with pytest.warns(DeprecationWarning):
with pytest.warns(DeprecationWarning, match="Group.tree instead"):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you prefer a regex matching the whole warning message?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the PT030 branch 2 times, most recently from 17e96dd to 196d54d Compare July 18, 2025 19:38
PT030 `pytest.warns(UserWarning)` is too broad,
      set the `match` parameter or use a more specific warning
@dstansby dstansby enabled auto-merge (squash) July 18, 2025 19:56
@dstansby dstansby merged commit abbdbf2 into zarr-developers:main Jul 18, 2025
28 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PT030 branch July 18, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants