use local imports in store ABC to avoid circular import issues #3372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zarr.abc.store
imports symbols from modules inzarr.core
; if you add a new ABC tozarr.abc.store
, and use it in one of the modules thatzarr.abc.store
is depending on inzarr.core
, you will get a circular import.This PR puts a band-aid on this problem by moving those imports to within the methods that actually need them. A better fix would be to re-organize the dependencies of this package so that we are structurally avoiding circularity. That can come later.
closes #3338
TODO:
docs/user-guide/*.rst
changes/