Skip to content

chore/remove chunk coords #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Aug 13, 2025

replaces all occurrences usage of ChunkCoords with tuple[int, ...]

I do keep the ChunkCoords definition in zarr.core.common in case someone was using it, since we do have people using our private API in the wild. Happy to remove this if people think it's safe.

closes #3373

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 13, 2025
ShapeLike = tuple[int, ...] | int
ChunkCoords = tuple[int, ...]
ChunkCoordsLike = Iterable[int]
ShapeLike = Iterable[int] | int
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this change, which better matches the intent of ShapeLike.

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Aug 13, 2025
@d-v-b d-v-b requested a review from a team August 13, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do we need the ChunkCoords type
1 participant