Skip to content

Raise more helpful errors in _dereference_path #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 3, 2025
Merged

Raise more helpful errors in _dereference_path #3392

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44b442f
Raise more helpful errors in _dereference_path
dstansby Aug 20, 2025
4808f21
Merge branch 'main' into deref-path-errors
d-v-b Aug 24, 2025
f5f6014
Merge branch 'main' into deref-path-errors
d-v-b Aug 25, 2025
221971c
Merge branch 'main' into deref-path-errors
dstansby Sep 3, 2025
254df58
Add some type ignore comments
dstansby Sep 3, 2025
31473ae
Merge branch 'main' into deref-path-errors
d-v-b Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/zarr/storage/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@


def _dereference_path(root: str, path: str) -> str:
assert isinstance(root, str)
assert isinstance(path, str)
if not isinstance(root, str):
msg = f"{root=} is not a string ({type(root)=})"
raise TypeError(msg)
if not isinstance(path, str):
msg = f"{path=} is not a string ({type(path)=})"
raise TypeError(msg)
root = root.rstrip("/")
path = f"{root}/{path}" if root else path
return path.rstrip("/")
Expand Down
Loading