Skip to content

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Sep 15, 2025

Closes #3458

This PR addresses two minor issues:

  • gzip still imports the old numcodecs.zarr3 implementation (see the issue: numcodecs.gzip is not configured in the config #3458 for more details)
  • The example at the top of zarr.codecs.numcodecs._codecs throws an error when run: module 'zarr.codecs.numcodecs' has no attribute 'zarr3'

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Sep 15, 2025
@d-v-b
Copy link
Contributor

d-v-b commented Sep 15, 2025

yay!

@d-v-b
Copy link
Contributor

d-v-b commented Sep 15, 2025

i think we can skip the release notes here

@K-Meech
Copy link
Contributor Author

K-Meech commented Sep 15, 2025

@d-v-b I've fixed the failing tests locally, but there's still a failure in the CI (only for python=3.11 / np=1.26 env). It seems to be from an un-related test function tests/test_sync.py::test_sync_timeout. Any idea what the issue is here?

@d-v-b
Copy link
Contributor

d-v-b commented Sep 15, 2025

@d-v-b I've fixed the failing tests locally, but there's still a failure in the CI (only for python=3.11 / np=1.26 env). It seems to be from an un-related test function tests/test_sync.py::test_sync_timeout. Any idea what the issue is here?

that's a flaky test that depends on the runtime of a function. it usually works if you trigger a re-run, but we can also ignore the failure

@d-v-b d-v-b enabled auto-merge (squash) September 15, 2025 16:07
@d-v-b d-v-b merged commit 62d1a6a into zarr-developers:main Sep 15, 2025
64 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numcodecs.gzip is not configured in the config
2 participants