Skip to content

Conversation

DimitriPapadopoulos
Copy link
Contributor

updates:

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Sep 22, 2025
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review September 22, 2025 20:54
Comment on lines 74 to 76
# mypy currently disallows class variables to contain type parameters
# but it seems OK for us to use it here:
# https://github.com/python/typing/discussions/1424#discussioncomment-7989934
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems inaccurate now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it seems. Removed.

updates:
- github.com/astral-sh/ruff-pre-commit: v0.12.11 → v0.13.1
- github.com/pre-commit/mirrors-mypy: v1.17.1 → v1.18.2
@d-v-b d-v-b merged commit 64c2bdc into zarr-developers:main Sep 22, 2025
47 of 50 checks passed
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.21%. Comparing base (24385ab) to head (e587480).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/zarr/core/dtype/wrapper.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3481   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files          84       84           
  Lines        9923     9923           
=======================================
  Hits         6074     6074           
  Misses       3849     3849           
Files with missing lines Coverage Δ
src/zarr/core/dtype/wrapper.py 10.63% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DimitriPapadopoulos DimitriPapadopoulos deleted the pre-commit branch September 23, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants