Skip to content

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Sep 22, 2025

fixes a typo leading to failure to register pcodec properly in the config.

this PR adds pcodec and zfpy to our main test dependencies. we should consider splitting these codecs out into their own dependency group if necessary.

I also fix some tests that were not running properly, and adapt some docstring tests to the new docs.

closes #3482

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Sep 22, 2025
@d-v-b d-v-b requested a review from rabernat September 22, 2025 21:36
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Sep 22, 2025
Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@d-v-b d-v-b enabled auto-merge (squash) September 23, 2025 08:06
@d-v-b
Copy link
Contributor Author

d-v-b commented Sep 23, 2025

I'm removing the pcodec test dependency because we do tests against an older version of numcodecs that used a different (incompatible) PCodec codec.

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.21%. Comparing base (0278494) to head (7dbb633).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/zarr/codecs/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3483   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files          84       84           
  Lines        9923     9923           
=======================================
  Hits         6074     6074           
  Misses       3849     3849           
Files with missing lines Coverage Δ
src/zarr/codecs/__init__.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b merged commit 48e7f4d into zarr-developers:main Sep 23, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCodec broken - UnknownCodecError
2 participants