-
-
Notifications
You must be signed in to change notification settings - Fork 364
fix pcodec resolution failure #3483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s, fix numcodec tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
I'm removing the pcodec test dependency because we do tests against an older version of numcodecs that used a different (incompatible) PCodec codec. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3483 +/- ##
=======================================
Coverage 61.21% 61.21%
=======================================
Files 84 84
Lines 9923 9923
=======================================
Hits 6074 6074
Misses 3849 3849
🚀 New features to boost your workflow:
|
fixes a typo leading to failure to register pcodec properly in the config.
this PR adds pcodec and zfpy to our main test dependencies. we should consider splitting these codecs out into their own dependency group if necessary.
I also fix some tests that were not running properly, and adapt some docstring tests to the new docs.
closes #3482