Feature: support rectilinear chunk grid extension #3534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3534 +/- ##
==========================================
+ Coverage 61.86% 62.20% +0.33%
==========================================
Files 85 85
Lines 10111 10522 +411
==========================================
+ Hits 6255 6545 +290
- Misses 3856 3977 +121
🚀 New features to boost your workflow:
|
…ature/rectilinear-chunk-grid
github-actions
bot
removed
the
needs release notes
d-v-b
reviewed
Oct 20, 2025
Comment on lines
+574
to
+575
| when you need to align chunks with existing data partitions. | ||
|
|
There was a problem hiding this comment.
Suggested change
| when you need to align chunks with existing data partitions. | |
| when you need to align chunks with existing data partitions. | |
| The specification for this chunking scheme can be found [here](https://github.com/zarr-developers/zarr-extensions/tree/main/chunk-grids/rectilinear/). |
This link doesn't resolve yet but it will when the spec is merged.
d-v-b
reviewed
Oct 20, 2025
Comment on lines
+614
to
+615
| With variable chunking, the standard `.chunks` property is not available since chunks | ||
| have different sizes. Instead, access chunk information through the chunk grid: |
There was a problem hiding this comment.
I think it would be better if .chunks just had a different type (tuple of tuples of ints)
d-v-b
reviewed
Oct 20, 2025
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class RectilinearChunkGrid(ChunkGrid): |
There was a problem hiding this comment.
thoughts on just calling this class Rectilinear, and renaming the RegularChunkGrid to Regular? We could keep around a RegularChunkGrid class for compatibility. But I feel like people know these are chunk grids when they import them
d-v-b
reviewed
Oct 20, 2025
d-v-b
reviewed
Oct 20, 2025
| ) | ||
|
|
||
| @cached_property | ||
| def _cumulative_sizes(self) -> tuple[tuple[int, ...], ...]: |
d-v-b
reviewed
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Marking this as a draft for now)
closes: #1595
replaces: #1483
xref: zarr-developers/zarr-extensions#25
TODO:
docs/user-guide/*.mdchanges/