Bump mimimum supported version of numpy #3636
Open
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3636 +/- ##
==========================================
- Coverage 60.90% 60.89% -0.01%
==========================================
Files 86 86
Lines 10174 10174
==========================================
- Hits 6196 6195 -1
- Misses 3978 3979 +1 🚀 New features to boost your workflow:
|
Contributor
|
No worries! As you can see that PR is mostly other things anyway |
d-v-b
reviewed
Jan 8, 2026
| matrix: | ||
| python-version: ['3.11', '3.12', '3.13'] | ||
| numpy-version: ['1.26', '2.2'] | ||
| numpy-version: ['2.0', '2.2'] |
Contributor
There was a problem hiding this comment.
After setting the minimum version to 2.0, do we still need different numpy versions in the test matrix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's been about six months since SPEC recommended removing support for NumPy 1.26, this bumps the minimum version to 2.0. This duplicates work in #3564, but I figured that it might be easier to do the version bumps (numpy and Python) independently since #3564 appears to have grown in scope quite a bit. ping @ilan-gold - I hope that's okay?
My motivation for doing this is the slowest test in the matrix seems to be the one with NumPy 1.26, so I'm hoping this improves the total time GH actions takes to run all the tests to completion.