-
Notifications
You must be signed in to change notification settings - Fork 32
Adds index_codecs to the sharding codec #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jbms
merged 6 commits into
zarr-developers:main
from
scalableminds:sharding-index-codecs
Jul 26, 2023
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
065cb0c
adds index_codecs to the sharding spec
normanrz 25ef408
tweaks
normanrz b8e3995
applied pr feedback
normanrz 72165cc
Update docs/v3/codecs/crc32c/v1.0.rst
normanrz f1cca01
clarified c.compute_encoded_size signature
normanrz 5924fc1
Update v3.0.rst
normanrz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| .. _crc32c-codec-v1: | ||
|
|
||
| ============================ | ||
| CRC32C checksum codec (version 1.0) | ||
| ============================ | ||
|
|
||
| **Editor's draft 26 July 2019** | ||
|
|
||
| Specification URI: | ||
| https://zarr-specs.readthedocs.io/en/latest/v3/codecs/endian/v1.0.html | ||
| Corresponding ZEP: | ||
| `ZEP 1 — Zarr specification version 3 <https://zarr.dev/zeps/draft/ZEP0001.html>`_ | ||
| Issue tracking: | ||
| `GitHub issues <https://github.com/zarr-developers/zarr-specs/labels/codec>`_ | ||
| Suggest an edit for this spec: | ||
| `GitHub editor <https://github.com/zarr-developers/zarr-specs/blob/main/docs/v3/codecs/endian/v1.0.rst>`_ | ||
|
|
||
| Copyright 2020 `Zarr core development team | ||
| <https://github.com/orgs/zarr-developers/teams/core-devs>`_. This work | ||
| is licensed under a `Creative Commons Attribution 3.0 Unported License | ||
| <https://creativecommons.org/licenses/by/3.0/>`_. | ||
|
|
||
| ---- | ||
|
|
||
|
|
||
| Abstract | ||
| ======== | ||
|
|
||
| Defines an ``bytes -> bytes`` codec that appends a CRC32C checksum of the input bytestream. | ||
|
|
||
|
|
||
| Status of this document | ||
| ======================= | ||
|
|
||
| .. warning:: | ||
| This document is a draft for review and subject to changes. | ||
| It will become final when the `Zarr Enhancement Proposal (ZEP) 2 <https://zarr.dev/zeps/draft/ZEP0002.html>`_ | ||
| is approved via the `ZEP process <https://zarr.dev/zeps/active/ZEP0000.html>`_. | ||
|
|
||
|
|
||
| Document conventions | ||
| ==================== | ||
|
|
||
| Conformance requirements are expressed with a combination of | ||
| descriptive assertions and [RFC2119]_ terminology. The key words | ||
| "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", | ||
| "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in the normative | ||
| parts of this document are to be interpreted as described in | ||
| [RFC2119]_. However, for readability, these words do not appear in all | ||
| uppercase letters in this specification. | ||
|
|
||
| All of the text of this specification is normative except sections | ||
| explicitly marked as non-normative, examples, and notes. Examples in | ||
| this specification are introduced with the words "for example". | ||
|
|
||
|
|
||
| Codec name | ||
| ========== | ||
|
|
||
| The value of the ``name`` member in the codec object MUST be ``crc32c``. | ||
|
|
||
|
|
||
| Configuration parameters | ||
| ======================== | ||
|
|
||
| None. | ||
|
|
||
|
|
||
| Format and algorithm | ||
| ==================== | ||
|
|
||
| This is an ``bytes -> bytes`` codec. | ||
|
|
||
| The codec computes the CRC32C checksum as defined in [RFC3720]_ of the input | ||
| bytestream. The output bytestream is composed of the unchanged input byte | ||
| stream with the appended checksum. The checksum is represented as a 32-bit | ||
| unsigned integer represented in little endian. | ||
|
|
||
|
|
||
| References | ||
| ========== | ||
|
|
||
| .. [RFC2119] S. Bradner. Key words for use in RFCs to Indicate | ||
| Requirement Levels. March 1997. Best Current Practice. URL: | ||
| https://tools.ietf.org/html/rfc2119 | ||
|
|
||
| .. [RFC3720] J. Satran et al. Internet Small Computer Systems | ||
| Interface (iSCSI). April 2004. Proposed Standard. URL: | ||
| https://tools.ietf.org/html/rfc3720 | ||
|
|
||
|
|
||
| Change log | ||
| ========== | ||
|
|
||
| No changes yet. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.