Skip to content

fix: stop using ChunkCoords #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

fix: stop using ChunkCoords #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/zarrs/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from zarr.core.array_spec import ArraySpec
from zarr.core.buffer import Buffer, NDArrayLike, NDBuffer
from zarr.core.chunk_grids import ChunkGrid
from zarr.core.common import ChunkCoords
from zarr.core.indexing import SelectorTuple
from zarr.dtype import ZDType

Expand Down Expand Up @@ -151,7 +150,7 @@ def __iter__(self) -> Iterator[Codec]:
yield from self.codecs

def validate(
self, *, shape: ChunkCoords, dtype: ZDType, chunk_grid: ChunkGrid
self, *, shape: tuple[int, ...], dtype: ZDType, chunk_grid: ChunkGrid
) -> None:
raise NotImplementedError("validate")

Expand Down
5 changes: 2 additions & 3 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import numpy.typing as npt
import pytest
from zarr import config
from zarr.core.common import ChunkCoords
from zarr.storage import FsspecStore, LocalStore, MemoryStore, ZipStore

from zarrs.utils import ( # noqa: F401
Expand All @@ -20,12 +19,12 @@
from typing import Any, Literal

from zarr.abc.store import Store
from zarr.core.common import ChunkCoords, MemoryOrder
from zarr.core.common import MemoryOrder


@dataclass
class ArrayRequest:
shape: ChunkCoords
shape: tuple[int, ...]
dtype: str
order: MemoryOrder

Expand Down
Loading