Skip to content

(fix): blosc v2 typesize in config #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

(fix): blosc v2 typesize in config #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e280999
(fix): blosc v2
ilan-gold Apr 9, 2025
142b5d0
Apply suggestions from code review
ilan-gold Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/zarrs/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,13 @@ def codecs_to_dict(codecs: Iterable[Codec]) -> Generator[dict[str, Any], None, N
else:
filters = None
if codec_dict.get("compressor", None) is not None:
compressor = json.dumps(codec_dict.get("compressor").get_config())
compressor_json = codec_dict.get("compressor").get_config()
# https://github.com/zarr-developers/numcodecs/pull/713 means
# typesize is always present, but it's not expected
# to be on v2 blosc codecs by zarrs.
if compressor_json["id"] == "blosc":
compressor_json.pop("typesize", None)
compressor = json.dumps(compressor_json)
else:
compressor = None
codecs_v3 = codec_metadata_v2_to_v3(filters, compressor)
Expand Down