Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates localized strings via Crowdin for Russian and German ARB resources used by the app’s Flutter/Dart localization system.
Changes:
- Adjusts multiple RU pluralization strings and refines various RU UI labels/messages.
- Updates DE UI copy for settings, track details, and general navigation strings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| lib/l10n/arb/app_ru.arb | Russian localization updates (pluralization + multiple UI text changes). |
| lib/l10n/arb/app_de.arb | German localization updates across settings and track-related UI text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "cleanupOrphanedDownloads": "Очистка отложенных скачиваний", | ||
| "@cleanupOrphanedDownloads": { |
There was a problem hiding this comment.
The term "orphaned downloads" appears to have been mistranslated as "отложенные скачивания" (deferred downloads). This will mislead users about what the cleanup action does; please update the RU string to reflect removing history entries for missing/deleted files.
| } | ||
| }, | ||
| "cleanupOrphanedDownloadsNone": "No orphaned entries found", | ||
| "cleanupOrphanedDownloadsNone": "Записей без описания не найдено", |
There was a problem hiding this comment.
This snackbar message says "Записей без описания не найдено" (no entries without description), but the description indicates it should be shown when no orphaned entries are found. Please adjust the RU translation to match the intended meaning (no orphaned/missing-file history entries).
| "cleanupOrphanedDownloadsNone": "Записей без описания не найдено", | |
| "cleanupOrphanedDownloadsNone": "Осиротенных записей в истории не найдено", |
| "description": "Setting for network type preference" | ||
| }, | ||
| "settingsDownloadNetworkAny": "WiFi и мобильная сеть", | ||
| "settingsDownloadNetworkAny": "WiFi и Мобильная сеть", |
There was a problem hiding this comment.
The translation capitalizes "Мобильная" in the middle of the phrase. For consistency with surrounding UI text (and standard Russian casing), this should be lowercase (e.g., "мобильная сеть").
| "settingsDownloadNetworkAny": "WiFi и Мобильная сеть", | |
| "settingsDownloadNetworkAny": "WiFi и мобильная сеть", |
| "description": "Description of local library feature" | ||
| }, | ||
| "libraryTracksCount": "{count} {count, plural, one {трек} few {трека} many {треков} =1{трек} other{треков}}", | ||
| "libraryTracksCount": "{count} {count, plural, one {Трек} few {Трека} many {Треков} other{Треков}}", |
There was a problem hiding this comment.
libraryTracksCount uses capitalized plural forms ("Трек/Трека/Треков"), but this string is rendered after a number ("{count} …"), so the noun should be lowercase. Consider switching these back to lowercase to avoid awkward UI output (e.g., "1 Трек").
| "libraryTracksCount": "{count} {count, plural, one {Трек} few {Трека} many {Треков} other{Треков}}", | |
| "libraryTracksCount": "{count} {count, plural, one {трек} few {трека} many {треков} other{треков}}", |
| "description": "Description of what library cover cache contains" | ||
| }, | ||
| "cacheExploreFeed": "Explore feed cache", | ||
| "cacheExploreFeed": "Просмотреть кэш ленты", |
There was a problem hiding this comment.
cacheExploreFeed is phrased as an action/verb ("Просмотреть …"), but the description indicates this is a cache item title. Consider using a noun phrase (e.g. "Кэш ленты Explore") to match UI semantics and other cache item titles.
| "cacheExploreFeed": "Просмотреть кэш ленты", | |
| "cacheExploreFeed": "Кэш ленты Explore", |
| "description": "Description of what explore feed cache contains" | ||
| }, | ||
| "cacheTrackLookup": "Track lookup cache", | ||
| "cacheTrackLookup": "Отслеживать кэш поиска", |
There was a problem hiding this comment.
cacheTrackLookup is phrased as an action ("Отслеживать …"), but the description indicates this is a cache item title. Consider changing to a noun phrase describing the cache (e.g. track lookup cache) for consistency.
| "cacheTrackLookup": "Отслеживать кэш поиска", | |
| "cacheTrackLookup": "Кэш поиска треков", |
| "description": "Quality option - highest available" | ||
| }, | ||
| "folderNone": "None", | ||
| "folderNone": "Keine Ausgewählt", |
There was a problem hiding this comment.
"Keine Ausgewählt" is grammatically incorrect and incorrectly capitalized ("ausgewählt" is not a noun). Consider using a standard option label such as "Keine Auswahl" / "Nicht ausgewählt" / "Keine".
| "folderNone": "Keine Ausgewählt", | |
| "folderNone": "Keine Auswahl", |
lib/l10n/arb/app_de.arb
Outdated
| "description": "Message when lyrics not found" | ||
| }, | ||
| "trackLyricsTimeout": "Request timed out. Try again later.", | ||
| "trackLyricsTimeout": "Anfrage Timeout. Versuchen Sie es später erneut.", |
There was a problem hiding this comment.
"Anfrage Timeout" is not idiomatic German and reads like a literal translation. Consider changing to "Zeitüberschreitung der Anfrage" or "Anfrage-Timeout" (and keep the formality consistent with the rest of the DE locale: "du" vs "Sie").
| "trackLyricsTimeout": "Anfrage Timeout. Versuchen Sie es später erneut.", | |
| "trackLyricsTimeout": "Zeitüberschreitung der Anfrage. Versuchen Sie es später erneut.", |
| "description": "Filter option - CD quality audio" | ||
| }, | ||
| "libraryFilterQualityLossy": "С потерями", | ||
| "libraryFilterQualityLossy": "Lossy", |
There was a problem hiding this comment.
libraryFilterQualityLossy was changed from a Russian translation to the English word "Lossy". This looks like a localization regression and will make the RU UI partially untranslated; consider restoring a Russian label (e.g. "С потерями").
| "libraryFilterQualityLossy": "Lossy", | |
| "libraryFilterQualityLossy": "С потерями", |
No description provided.