Dont block executor when syncing files or mutexes#32
Merged
Conversation
falkoschindler
approved these changes
Feb 4, 2026
Contributor
falkoschindler
left a comment
There was a problem hiding this comment.
Code looks good to me.
Assuming you successfully tested it, the PR is ready to merge. 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been noticing for some time now that syncs sometimes take longer than expected (which is really confusing and annoying when you then accidentally execute old code on a remote machine...).
Investigation showed that the sync process itself is started late. The reason for that is that other tasks running subprocesses were doing so in a blocking fashion and thus preventing the executor from executing other tasks in the mean time. In this concrete example the mutex task was hindering a folder sync task from being executed. When syncing to two folders simultaneously the same could happen, though. Notably, this does not result in parallel sync to the same folder (which would be undesirable) because the folder sync task itself is waiting for the sync process to finish.
Fix: Use asyncio.subprocess instead of subprocess.check_output (or similar) and mark the functions async.