Load codehilite.css faster (cache headers, file name hash cache-busting) #5497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on #5493 I also noticed that, full cached, NiceGUI documentation reaches out to:
index.html(obviously)codehilite.cssThe latter we should be able to get rid of?
Implementation
${this.filename}with the accompanying props._generate_codehilite_css(), which is shared.@lru_cache(maxsize=1)to_generate_codehilite_css()because it doesn't ever change in runtime (an asusmption, is this right?)Progress
Results
Slow 4G no CPU throttling (because network is the bottleneck)
Before: 1.46s load
After: 1.00s load