set timeout_graceful_shutdown to prevent hanging on ConnectionResetError #5706
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ConnectionResetError occurs (particularly with multiple videos in native mode on Windows), the server may hang indefinitely. By setting timeout_graceful_shutdown (default 10 seconds), the server will forcefully terminate requests after this timeout elapses, ensuring the application exits rather than hanging. Fixes zauberzeug#5443 Co-Authored-By: Claude Opus 4.5 <[email protected]>
falkoschindler
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #5443, where when ConnectionResetError occurs (particularly with multiple videos in native mode on Windows), the server may hang indefinitely, unresponsive to Ctrl+C termination.
Additional debugging context in #5700's comments.
Implementation
By setting timeout_graceful_shutdown (default 10 seconds, which is plenty long, considering Redis also times out in 10 seconds), the server will forcefully terminate requests after this timeout elapses, ensuring the application exits rather than hanging.
Progress
Final notes
It appears that
ConnectionResetErroris inevitable on Windows. Nevertheless I think this PR is also good to ensure a bounded-wait termination (surprised it isn't originally the case tbh)CC @python-and-novella
At this point we can consider to cherry-pick: