Fix material settings not applying to GLTF models #5708
+20
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #3515, where GLTF models load asynchronously as Groups, so material settings were being ignored.
Particularly, there are 3 cases to resolve (from #3515 (comment)):
NOTE: right now the test sample I can only test the GLTF case, not the
groupcase though.Implementation
TL-DR: Now stores pending material info on Group objects and applies settings to all mesh children after the model loads.
Material handling improvements:
materialmethod: Now, if the target object is a group (e.g., a GLTF model), material settings are stored inpendingMaterialInfoand applied to all child meshes once the group is loaded. For non-group objects, material settings are applied directly.applyMaterialSettingsmethod to encapsulate the logic for updating material properties and refactored existing code to use this method.GLTF loading enhancements:
pendingMaterialInfoon a group after loading, and apply material settings to all child meshes usingapplyMaterialSettings. This ensures that material updates requested before model load are not lost.Progress