Merged
Conversation
Contributor
Author
|
Let's see if the pipeline agrees with this solution... |
evnchn
previously approved these changes
Feb 19, 2026
Collaborator
evnchn
left a comment
There was a problem hiding this comment.
Mergeable as-is, but prefer robustified timings.
evnchn
reviewed
Feb 19, 2026
Collaborator
evnchn
left a comment
There was a problem hiding this comment.
The commit doesnt show up -> use this instead
Co-authored-by: Evan Chan <37951241+evnchn@users.noreply.github.com>
Collaborator
|
It should be 1.0 but 1 also works. Anyways I'm eager to close this ASAP (in family dinner btw) |
evnchn
approved these changes
Feb 19, 2026
Collaborator
evnchn
left a comment
There was a problem hiding this comment.
tests/test_page.py .......................... [ 55%]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The test
test_warning_if_response_takes_too_longis flaky in CI. When the page'sresponse_timeoutfires and the client is deleted, the resulting incomplete page response causes Selenium'sget()to hang until its internal script timeout (~30s), throwing aTimeoutExceptionbefore the test's log assertion is ever reached. This has been observed failing on Python 3.10 and 3.14 in CI (example run).Implementation
Replace
screen.open('/')with a plainhttpx.get()request. The test only verifies that a server-side warning is logged — it doesn't need a fully loaded browser page. Usinghttpxavoids Selenium entirely, eliminating the script timeout issue while keeping the same assertion.Progress