Skip to content

Update reaktiv example to use non-leaking version#5820

Closed
evnchn wants to merge 1 commit intomainfrom
evnchn-patch-1
Closed

Update reaktiv example to use non-leaking version#5820
evnchn wants to merge 1 commit intomainfrom
evnchn-patch-1

Conversation

@evnchn
Copy link
Collaborator

@evnchn evnchn commented Feb 19, 2026

Motivation

The example code pattern that previously leaked subscriptions was already fixed in the example. This PR makes the complementary change: it bumps the reaktiv dependency used by the example to the release that contains the non-leaking fix so users get the corrected behavior without further code changes. No related issue exists.

Implementation

  • Bump the reaktiv dependency/version used by the example to the release that includes the non-leaking fix.
  • The example code itself is unchanged; this is a minimal dependency update (one-line change) that ensures the example does not increase memory/resource usage over time.
  • Low-risk change limited to the example dependency specification.

Progress

  • I chose a meaningful title that completes the sentence: "If applied, this PR will bump the reaktiv dependency used by the example to a version that fixes subscription/resource leaks"
  • The implementation is complete.
  • If this PR addresses a security issue, it has been coordinated via the [security advisory] (not applicable).
  • Pytests have been added (or are not necessary).
  • Documentation has been added (or is not necessary).

Final notes

I'm on the bus, this is written by GitHub Copilot. Please cut me some slack 🙇

@evnchn evnchn enabled auto-merge February 19, 2026 14:13
@evnchn evnchn added the documentation Type/scope: Documentation, examples and website label Feb 19, 2026
@falkoschindler falkoschindler added the review Status: PR is open and needs review label Feb 19, 2026
@falkoschindler
Copy link
Contributor

Thanks, @evnchn! However, I don't think this change is necessary.

PR #5812 fixed the example code so that Effects are properly held in variables instead of being garbage collected while still in use. With that fix in place, the example works correctly on reaktiv>=0.21.1.

The leak fix in reaktiv 0.21.2 addresses a bug in the reaktiv library itself - but it's not the example's job to pin dependencies to work around bugs in third-party libraries. Users will naturally get the latest version via pip install anyway since we use >=.

Therefore I'm closing this PR.

auto-merge was automatically disabled February 19, 2026 15:03

Pull request was closed

@evnchn evnchn deleted the evnchn-patch-1 branch February 19, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Type/scope: Documentation, examples and website review Status: PR is open and needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments