Update reaktiv example to use non-leaking version#5820
Closed
Conversation
Contributor
|
Thanks, @evnchn! However, I don't think this change is necessary. PR #5812 fixed the example code so that Effects are properly held in variables instead of being garbage collected while still in use. With that fix in place, the example works correctly on The leak fix in reaktiv 0.21.2 addresses a bug in the reaktiv library itself - but it's not the example's job to pin dependencies to work around bugs in third-party libraries. Users will naturally get the latest version via Therefore I'm closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The example code pattern that previously leaked subscriptions was already fixed in the example. This PR makes the complementary change: it bumps the reaktiv dependency used by the example to the release that contains the non-leaking fix so users get the corrected behavior without further code changes. No related issue exists.
Implementation
Progress
Final notes
I'm on the bus, this is written by GitHub Copilot. Please cut me some slack 🙇