ynl-gen-cpp: add support for generating tc #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces the `TypeBinaryStruct` class to handle attributes that are of binary type and structured as a `struct` in the `rt-addr`. Unlike the standard `TypeBinary`, `TypeBinaryStruct` has a defined structure, so the `struct_member` should be `optional<T>` and the `presence_type` is `flag`. Signed-off-by: Zibo Gong <[email protected]>
This patch add basic support for netlink-raw protocol. The support can correctly generate rt-addr. To test that, a rt-addr test added in samples/. Signed-off-by: Zibo Gong <[email protected]>
Better format for C++ lambda: a space between return type and function body. Signed-off-by: Zibo Gong <[email protected]>
rt- family can contain - in its family name. It should be correct to use c_name. Signed-off-by: Zibo Gong <[email protected]>
The patch fixes an issue in the determination of type_consistent. It used to set type_consistent to be False when dump exists but do does not exist. This is inaccurate and will lead to exceptions. This case should be treated as consistent but one-sided. Signed-off-by: Zibo Gong <[email protected]>
zb-gong
force-pushed
the
rt_family
branch
9 times, most recently
from
6a5134b to
d44dc67
Compare
zb-gong
force-pushed
the
rt_family
branch
4 times, most recently
from
2bced26 to
83dcd08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To generate tc, there is a notable bug to fix:
Previously, when a struct member was recursive (i.e., it referenced the same type), the generator incorrectly emitted it as a
std::vector. However, recursive members should be represented as a pointer.This PR corrects the logic by using
std::unique_ptrand updating the related code accordingly.tc-related kernel (fa582ca7e187) files are copied.