Skip to content

Conversation

@ahesford
Copy link
Member

This needs testing.

I can't think of a single legitimate use for storing ZFS encryption keys on an unencrypted ZFS filesystem. People can do it if they want, but we don't need to help them make bad choices by copying their unencrypted keys via our caching mechanism.

@zdykstra
Copy link
Member

Might be nice to add a zerror or zwarn message indicating that the key source can't be used because it's not encrypted.

@ahesford
Copy link
Member Author

Moved from zdebug to zwarn.

@zdykstra
Copy link
Member

Tested locally with org.zfsbootmenu:keysource pointing to an un-encrypted dataset; works as expected. No keys are cached and the main menu forces a passphrase input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants