zfsbootmenu: support per-kernel command-line arguments #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahesford
force-pushed
the
who_jacked_da_fuckin_truck
branch
5 times, most recently
from
5d0c302 to
b316a82
Compare
ahesford
force-pushed
the
who_jacked_da_fuckin_truck
branch
from
b316a82 to
d1576b1
Compare
zdykstra
reviewed
Jan 14, 2026
Member
zdykstra
left a comment
zdykstra
left a comment
There was a problem hiding this comment.
With the new /zfsbootmenu/$environment/kcl directory structure, should the value derived from OS initramfs defaults/ZFS property that's currently stored as /zfsbootmenu/$environment/cmdline be moved under the kcl/ directory to have them all in a single place? There's no way that filenames will conflict.
| cat <<EOF | ||
| ENTER A NEW KERNEL COMMAND LINE | ||
| - Interrupt with Ctrl+C or specify an empty line to cancel input |
Member
There was a problem hiding this comment.
This is sorta unrelated to the PR, but how do we handle the user wanting an empty KCL so that the internal default for the detected initramfs is used? Ideally an empty line should be accepted and not used to cancel input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough sketch for now. It could use a bit of refining, andzfsbootmenu-previewis unaware of the selected kernel, which means that the kernel version never updates in the header and, now, neither does the KCL.I think I've worked out the kinks, and everything respects the changing kernel.