Refactor command execution in bundler and gemset modules #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitallium
force-pushed
the
vs/add-tests
branch
3 times, most recently
from
765c6c1 to
b81c552
Compare
This refactoring improves the architecture and testability of the Ruby extension by introducing abstractions for command execution. Key changes: - Add `CommandExecutor` trait for bundle commands with default impl - Add `GemCommandExecutor` trait for gem commands with default impl - Refactor Bundler and Gemset to accept executors via DI The refactoring enables better testing through mock implementations while keeping the original functionality intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring improves the architecture and testability of the Ruby extension by introducing abstractions for command execution. Key changes:
CommandExecutortrait for bundle commands with default implGemCommandExecutortrait for gem commands with default implThe refactoring enables better testing through mock implementations while keeping the original functionality intact.