Add TypeScript declaration files and integration tests #237
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Charles Covey-Brandt.
|
- Enable declaration file generation in tsconfig.json - Add types field and exports to package.json - Add comprehensive integration test that verifies: - Full packaging flow (build → pack → install → type-check) - Main exports type-check correctly - Deep imports work (backwards compatibility) - Type shapes match expected interfaces - Generic types work correctly The integration test simulates the real package installation experience by creating a tarball and installing it in temporary TypeScript projects. This ensures declaration files work correctly for package consumers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
chazcb
force-pushed
the
add-typescript-declarations
branch
from
049a783 to
f77f108
Compare
|
We require contributors to sign our Contributor License Agreement, and we don't have @chazcb on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Ensures the test always runs with a fresh build and properly validates that declaration files are being generated, not just leftover from previous builds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
We require contributors to sign our Contributor License Agreement, and we don't have @chazcb on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @chazcb on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @chazcb on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
2 participants
Summary
.d.tsand.d.ts.map)typesfield and properexportsconfiguration to package.jsonChanges
Build Configuration
declaration: trueanddeclarationMap: truetypesfield andexportsfield with:typesandimportconditions"./*": "./*"to preserve backwards compatibility for deep importsIntegration Test
The new test at
src/tests/typescript-declarations.test.tsvalidates:dist/*.jsimportsThe test creates temporary TypeScript projects, installs the actual
.tgzpackage, and runstsc --noEmitto verify type-checking passes.Test plan
npm run buildgenerates.d.tsand.d.ts.mapfiles indist/npm run test:integration -- typescript-declarations🤖 Generated with Claude Code