ruby: Add note about enabling Ruby LSP for ERB files#41851
ruby: Add note about enabling Ruby LSP for ERB files#41851osiewicz merged 1 commit intozed-industries:mainfrom
Conversation
cla-bot
bot
added
the
cla-signed
github-actions
bot
added
the
community champion
| "Ruby": { | ||
| "language_servers": ["ruby-lsp", "!solargraph", "!rubocop", "..."] | ||
| }, | ||
| // Enable herb and ruby-lsp for *.html.erb files |
There was a problem hiding this comment.
herb is enabled by default for *.html.erb.
| }, | ||
| // Enable herb and ruby-lsp for *.html.erb files | ||
| "HTML+ERB": { | ||
| "language_servers": ["herb", "ruby-lsp", "..."] |
There was a problem hiding this comment.
Following the note above, I think we could leave it as ["ruby-lsp", "..."] but I want to show that we explicitly enable both herb and ruby-lsp.
|
/cc @marcoroth |
|
Dumb question: does it hurt to keep |
In some way, yes, it does. Zed uses Adding a requirement in enabling |
Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
…41851) Hi, this is a follow-up change for zed-industries#41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
…41851) Hi, this is a follow-up change for zed-industries#41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
3 participants
Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks!
Release Notes: