Skip to content

copilot: Wire up reasoning tokens for GPT models#53313

Open
TwistingTwists wants to merge 1 commit intozed-industries:mainfrom
TwistingTwists:2026-03-reasoning-tokens
Open

copilot: Wire up reasoning tokens for GPT models#53313
TwistingTwists wants to merge 1 commit intozed-industries:mainfrom
TwistingTwists:2026-03-reasoning-tokens

Conversation

@TwistingTwists
Copy link
Copy Markdown

@TwistingTwists TwistingTwists commented Apr 7, 2026 •
edited by mikayla-maki
Loading

Fix two issues with reasoning support in the Copilot provider:

  • Responses API path: use the user's thinking_effort setting instead of hardcoding Medium effort
  • Chat Completions path: compute and pass thinking_budget when thinking is enabled, instead of unconditionally setting it to None

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #52140

Release Notes:

  • Fixed a bug where copilot wouldn't use the thinking level the user's have set

@TwistingTwists
copilot: Wire up reasoning tokens for GPT models
ceb788f 
Fix two issues with reasoning support in the Copilot provider:

- Responses API path: use the user's thinking_effort setting instead of
  hardcoding Medium effort
- Chat Completions path: compute and pass thinking_budget when thinking
  is enabled, instead of unconditionally setting it to None
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 7, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested a review from a team April 7, 2026 15:02
@zed-community-bot zed-community-bot bot added the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Apr 7, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from danilo-leal and maxbrunsfeld and removed request for a team April 7, 2026 15:02
@zed-community-bot zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Apr 7, 2026
@TwistingTwists TwistingTwists marked this pull request as draft April 7, 2026 15:03
@danilo-leal danilo-leal removed their assignment Apr 7, 2026
@TwistingTwists TwistingTwists marked this pull request as ready for review April 8, 2026 02:06
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested a review from a team April 8, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikayla-maki mikayla-maki mikayla-maki approved these changes

@maxbrunsfeld maxbrunsfeld Awaiting requested review from maxbrunsfeld maxbrunsfeld was automatically assigned from zed-industries/ai-team

@danilo-leal danilo-leal Awaiting requested review from danilo-leal danilo-leal was automatically assigned from zed-industries/ai-team

Assignees

@danilo-leal danilo-leal

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GPT-models like GPT 5.4 from Github Copilot do not use reasoning

3 participants

@TwistingTwists @mikayla-maki @danilo-leal