sidebar: Rename next/prev actions and small fix#53333
Open
cameron1024 wants to merge 5 commits intomainfrom
Open
sidebar: Rename next/prev actions and small fix#53333cameron1024 wants to merge 5 commits intomainfrom
cameron1024 wants to merge 5 commits intomainfrom
Conversation
cla-bot
bot
added
the
cla-signed
zed-community-bot
bot
added
the
staff
mikayla-maki
reviewed
Apr 7, 2026
cameron1024
force-pushed
the
tab-switcher-2
branch
from
7323e4e to
d1bff04
Compare
mikayla-maki
reviewed
Apr 8, 2026
| if let Some(sidebar) = &self.sidebar { | ||
| let focus_handle = sidebar.focus_handle(cx); | ||
| window.defer(cx, move |window, cx| { | ||
| focus_handle.dispatch_action(&*action, window, cx); |
Member
There was a problem hiding this comment.
Rather than dispatching to the sidebar, we should do this more like the tab switcher. That way, we keep sidebar related logic in the sidebar, but still can have global actions:
https://github.com/zed-industries/zed/blob/main/crates/tab_switcher/src/tab_switcher.rs#L66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctness fix + renaming the actions
Release Notes: