multibuffer: Speed up anchor resolution by avoiding an excerpts seek#53340
Merged
cole-miller merged 2 commits intomainfrom Apr 7, 2026
Merged
multibuffer: Speed up anchor resolution by avoiding an excerpts seek#53340cole-miller merged 2 commits intomainfrom
cole-miller merged 2 commits intomainfrom
Conversation
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
ConradIrwin
approved these changes
Apr 7, 2026
Member
ConradIrwin
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks!
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, every creation of
AnchorSeekTargetcalledMultiBufferSnapshot::buffer_for_path, which seeks the excerpts sum tree. Now we avoid that bybuffersmap (keyed byBufferId)AnchorSeekTarget::MissingvariantWe also added a separate optimization to
AnchorSeekTarget::cmp, to skip the fullPathKeycomparison when the cursor'sPathKeyIndexis the same as the anchor's. This should help with singleton multibuffers.Self-Review Checklist:
Release Notes: