Fix debugger start ignoring save property#53353
Open
OmChillure wants to merge 1 commit intozed-industries:mainfrom
Open
Fix debugger start ignoring save property#53353OmChillure wants to merge 1 commit intozed-industries:mainfrom
OmChillure wants to merge 1 commit intozed-industries:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
debugger::Startruns a build task (via the"build"field indebug.json), it was bypassing the task's"save"property and callingproject.create_terminal_task()directly. This meant unsaved files were never saved before the build ran, even when"save": "all"was set unliketask: spawnwhich correctly saved first.Changes:
Workspace::save_for_task(workspace, strategy, cx)as a shared async helper inworkspace/src/tasks.rsschedule_resolved_taskto call this helper (no behavior change, removes inline duplication)RunningState::resolve_scenariobeforecreate_terminal_task, so the debugger build path now respects the task'ssavestrategytest_save_for_task_all,test_save_for_task_current, andtest_save_for_task_nonetests covering the extracted helper directlySelf-Review Checklist
Closes #53284
Video after fix
Screencast.from.2026-04-08.08-04-18.webm
Release Notes:
"save": "all"is set in the task definition