Conversation
|
@romnn is attempting to deploy a commit to the Gustav Westling's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @romnn, thanks for the PR. What would be the difference between the |
|
Thanks for the response and good question! They are equivalent in that both skip all checks for a resource, so supporting only one of them is also an option.
There are some subtle differences:
I agree that there could be some confusion around this. Both are intuitive in my opinion, but I'd gladly hear your opinion on this! |
Thank you very much for this fantastic tool!!
I came across the use case to disable all checks for a file, more precisely the Helm
test-connnectionpod often found in Helm charts.This PR proposes skipping all checks for a file (
"kube-score/skip": "true") and checks ("kube-score/ignore": "*") using annotations. The root level annotation is checked on a per-file basis during parsing and tracked in theFileLocation, which allows further differentiation between ignored checks and skipped files. Additionally, nested annotations are checked on a per-check basis similar to thekube-score/ignoreannotation.I greatly appreciate any feedback if this is something you agree could be useful.
Best, Roman
Note: Unfortunately, the tests do not pass due an unrelated issue that I am not familiar with, once this is resolved I plan to merge the fix back into this PR.