Skip to content

Commit bea3bd7

Browse files
authored
Apply javadoc updates to other modules (open-telemetry#15857)
1 parent 7b06845 commit bea3bd7

File tree

16 files changed

+166
-242
lines changed

16 files changed

+166
-242
lines changed

instrumentation/apache-httpclient/apache-httpclient-4.3/library/src/main/java/io/opentelemetry/instrumentation/apachehttpclient/v4_3/ApacheHttpClientTelemetry.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,12 @@
1515
/** Entrypoint for instrumenting Apache HTTP Client. */
1616
public final class ApacheHttpClientTelemetry {
1717

18-
/**
19-
* Returns a new {@link ApacheHttpClientTelemetry} configured with the given {@link
20-
* OpenTelemetry}.
21-
*/
18+
/** Returns a new instance configured with the given {@link OpenTelemetry} instance. */
2219
public static ApacheHttpClientTelemetry create(OpenTelemetry openTelemetry) {
2320
return builder(openTelemetry).build();
2421
}
2522

26-
/**
27-
* Returns a new {@link ApacheHttpClientTelemetryBuilder} configured with the given {@link
28-
* OpenTelemetry}.
29-
*/
23+
/** Returns a builder configured with the given {@link OpenTelemetry} instance. */
3024
public static ApacheHttpClientTelemetryBuilder builder(OpenTelemetry openTelemetry) {
3125
return new ApacheHttpClientTelemetryBuilder(openTelemetry);
3226
}
@@ -41,13 +35,13 @@ public static ApacheHttpClientTelemetryBuilder builder(OpenTelemetry openTelemet
4135
this.propagators = propagators;
4236
}
4337

44-
/** Returns a new {@link CloseableHttpClient} with tracing configured. */
38+
/** Returns an instrumented HTTP client. */
4539
public CloseableHttpClient createHttpClient() {
4640
return createHttpClientBuilder().build();
4741
}
4842

4943
/**
50-
* Returns a new {@link CloseableHttpClient} with tracing configured.
44+
* Returns an instrumented HTTP client.
5145
*
5246
* @deprecated Use {@link #createHttpClient()} instead.
5347
*/
@@ -56,13 +50,13 @@ public CloseableHttpClient newHttpClient() {
5650
return createHttpClient();
5751
}
5852

59-
/** Returns a new {@link HttpClientBuilder} to create a client with tracing configured. */
53+
/** Returns a builder for creating an instrumented HTTP client. */
6054
public HttpClientBuilder createHttpClientBuilder() {
6155
return new TracingHttpClientBuilder(instrumenter, propagators);
6256
}
6357

6458
/**
65-
* Returns a new {@link HttpClientBuilder} to create a client with tracing configured.
59+
* Returns a builder for creating an instrumented HTTP client.
6660
*
6761
* @deprecated Use {@link #createHttpClientBuilder()} instead.
6862
*/

instrumentation/apache-httpclient/apache-httpclient-4.3/library/src/main/java/io/opentelemetry/instrumentation/apachehttpclient/v4_3/ApacheHttpClientTelemetryBuilder.java

Lines changed: 15 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import java.util.function.UnaryOperator;
1717
import org.apache.http.HttpResponse;
1818

19-
/** A builder for {@link ApacheHttpClientTelemetry}. */
19+
/** Builder for {@link ApacheHttpClientTelemetry}. */
2020
public final class ApacheHttpClientTelemetryBuilder {
2121

2222
private static final String INSTRUMENTATION_NAME = "io.opentelemetry.apache-httpclient-4.3";
@@ -36,8 +36,8 @@ public final class ApacheHttpClientTelemetryBuilder {
3636
}
3737

3838
/**
39-
* Adds an additional {@link AttributesExtractor} to invoke to set attributes to instrumented
40-
* items. The {@link AttributesExtractor} will be executed after all default extractors.
39+
* Adds an {@link AttributesExtractor} to extract attributes from requests and responses. Executed
40+
* after all default extractors.
4141
*/
4242
@CanIgnoreReturnValue
4343
public ApacheHttpClientTelemetryBuilder addAttributesExtractor(
@@ -47,9 +47,9 @@ public ApacheHttpClientTelemetryBuilder addAttributesExtractor(
4747
}
4848

4949
/**
50-
* Configures the HTTP request headers that will be captured as span attributes.
50+
* Configures HTTP request headers to capture as span attributes.
5151
*
52-
* @param requestHeaders A list of HTTP header names.
52+
* @param requestHeaders HTTP header names to capture.
5353
*/
5454
@CanIgnoreReturnValue
5555
public ApacheHttpClientTelemetryBuilder setCapturedRequestHeaders(
@@ -59,9 +59,9 @@ public ApacheHttpClientTelemetryBuilder setCapturedRequestHeaders(
5959
}
6060

6161
/**
62-
* Configures the HTTP response headers that will be captured as span attributes.
62+
* Configures HTTP response headers to capture as span attributes.
6363
*
64-
* @param responseHeaders A list of HTTP header names.
64+
* @param responseHeaders HTTP header names to capture.
6565
*/
6666
@CanIgnoreReturnValue
6767
public ApacheHttpClientTelemetryBuilder setCapturedResponseHeaders(
@@ -71,16 +71,15 @@ public ApacheHttpClientTelemetryBuilder setCapturedResponseHeaders(
7171
}
7272

7373
/**
74-
* Configures the instrumentation to recognize an alternative set of HTTP request methods.
74+
* Configures recognized HTTP request methods.
7575
*
76-
* <p>By default, this instrumentation defines "known" methods as the ones listed in <a
77-
* href="https://www.rfc-editor.org/rfc/rfc9110.html#name-methods">RFC9110</a> and the PATCH
78-
* method defined in <a href="https://www.rfc-editor.org/rfc/rfc5789.html">RFC5789</a>.
76+
* <p>By default, recognizes methods from <a
77+
* href="https://www.rfc-editor.org/rfc/rfc9110.html#name-methods">RFC9110</a> and PATCH from <a
78+
* href="https://www.rfc-editor.org/rfc/rfc5789.html">RFC5789</a>.
7979
*
80-
* <p>Note: calling this method <b>overrides</b> the default known method sets completely; it does
81-
* not supplement it.
80+
* <p><b>Note:</b> This <b>overrides</b> defaults completely; it does not supplement them.
8281
*
83-
* @param knownMethods A set of recognized HTTP request methods.
82+
* @param knownMethods HTTP request methods to recognize.
8483
* @see HttpClientAttributesExtractorBuilder#setKnownMethods(Collection)
8584
*/
8685
@CanIgnoreReturnValue
@@ -89,21 +88,15 @@ public ApacheHttpClientTelemetryBuilder setKnownMethods(Collection<String> known
8988
return this;
9089
}
9190

92-
/**
93-
* Sets a customizer that receives the default {@link SpanNameExtractor} and returns a customized
94-
* one.
95-
*/
91+
/** Customizes the {@link SpanNameExtractor} by transforming the default instance. */
9692
@CanIgnoreReturnValue
9793
public ApacheHttpClientTelemetryBuilder setSpanNameExtractorCustomizer(
9894
UnaryOperator<SpanNameExtractor<ApacheHttpClientRequest>> spanNameExtractorCustomizer) {
9995
builder.setSpanNameExtractorCustomizer(spanNameExtractorCustomizer);
10096
return this;
10197
}
10298

103-
/**
104-
* Returns a new {@link ApacheHttpClientTelemetry} configured with this {@link
105-
* ApacheHttpClientTelemetryBuilder}.
106-
*/
99+
/** Returns a new instance with the configured settings. */
107100
public ApacheHttpClientTelemetry build() {
108101
return new ApacheHttpClientTelemetry(builder.build(), openTelemetry.getPropagators());
109102
}

instrumentation/armeria/armeria-1.3/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_3/ArmeriaClientTelemetry.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515
/** Entrypoint for instrumenting Armeria clients. */
1616
public final class ArmeriaClientTelemetry {
1717

18-
/**
19-
* Returns a new {@link ArmeriaClientTelemetry} configured with the given {@link OpenTelemetry}.
20-
*/
18+
/** Returns a new instance configured with the given {@link OpenTelemetry} instance. */
2119
public static ArmeriaClientTelemetry create(OpenTelemetry openTelemetry) {
2220
return builder(openTelemetry).build();
2321
}
2422

23+
/** Returns a builder configured with the given {@link OpenTelemetry} instance. */
2524
public static ArmeriaClientTelemetryBuilder builder(OpenTelemetry openTelemetry) {
2625
return new ArmeriaClientTelemetryBuilder(openTelemetry);
2726
}
@@ -32,10 +31,7 @@ public static ArmeriaClientTelemetryBuilder builder(OpenTelemetry openTelemetry)
3231
this.instrumenter = instrumenter;
3332
}
3433

35-
/**
36-
* Returns a new {@link HttpClient} decorator for use with methods like {@link
37-
* com.linecorp.armeria.client.ClientBuilder#decorator(Function)}.
38-
*/
34+
/** Returns a decorator for instrumenting Armeria clients. */
3935
public Function<? super HttpClient, ? extends HttpClient> newDecorator() {
4036
return client -> new OpenTelemetryClient(client, instrumenter);
4137
}

instrumentation/armeria/armeria-1.3/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_3/ArmeriaClientTelemetryBuilder.java

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ public final class ArmeriaClientTelemetryBuilder {
3636
builder = ArmeriaInstrumenterBuilderFactory.getClientBuilder(openTelemetry);
3737
}
3838

39-
/**
40-
* Sets a customizer that receives the default {@link SpanStatusExtractor} and returns a
41-
* customized one.
42-
*/
39+
/** Customizes the {@link SpanStatusExtractor} by transforming the default instance. */
4340
@CanIgnoreReturnValue
4441
public ArmeriaClientTelemetryBuilder setSpanStatusExtractorCustomizer(
4542
UnaryOperator<SpanStatusExtractor<ClientRequestContext, RequestLog>>
@@ -49,8 +46,8 @@ public ArmeriaClientTelemetryBuilder setSpanStatusExtractorCustomizer(
4946
}
5047

5148
/**
52-
* Adds an extra {@link AttributesExtractor} to invoke to set attributes to instrumented items.
53-
* The {@link AttributesExtractor} will be executed after all default extractors.
49+
* Adds an {@link AttributesExtractor} to extract attributes from requests and responses. Executed
50+
* after all default extractors.
5451
*/
5552
@CanIgnoreReturnValue
5653
public ArmeriaClientTelemetryBuilder addAttributesExtractor(
@@ -60,9 +57,9 @@ public ArmeriaClientTelemetryBuilder addAttributesExtractor(
6057
}
6158

6259
/**
63-
* Configures the HTTP client request headers that will be captured as span attributes.
60+
* Configures HTTP request headers to capture as span attributes.
6461
*
65-
* @param requestHeaders A list of HTTP header names.
62+
* @param requestHeaders HTTP header names to capture.
6663
*/
6764
@CanIgnoreReturnValue
6865
public ArmeriaClientTelemetryBuilder setCapturedRequestHeaders(
@@ -72,9 +69,9 @@ public ArmeriaClientTelemetryBuilder setCapturedRequestHeaders(
7269
}
7370

7471
/**
75-
* Configures the HTTP client response headers that will be captured as span attributes.
72+
* Configures HTTP response headers to capture as span attributes.
7673
*
77-
* @param responseHeaders A list of HTTP header names.
74+
* @param responseHeaders HTTP header names to capture.
7875
*/
7976
@CanIgnoreReturnValue
8077
public ArmeriaClientTelemetryBuilder setCapturedResponseHeaders(
@@ -84,16 +81,15 @@ public ArmeriaClientTelemetryBuilder setCapturedResponseHeaders(
8481
}
8582

8683
/**
87-
* Configures the instrumentation to recognize an alternative set of HTTP request methods.
84+
* Configures recognized HTTP request methods.
8885
*
89-
* <p>By default, this instrumentation defines "known" methods as the ones listed in <a
90-
* href="https://www.rfc-editor.org/rfc/rfc9110.html#name-methods">RFC9110</a> and the PATCH
91-
* method defined in <a href="https://www.rfc-editor.org/rfc/rfc5789.html">RFC5789</a>.
86+
* <p>By default, recognizes methods from <a
87+
* href="https://www.rfc-editor.org/rfc/rfc9110.html#name-methods">RFC9110</a> and PATCH from <a
88+
* href="https://www.rfc-editor.org/rfc/rfc5789.html">RFC5789</a>.
9289
*
93-
* <p>Note: calling this method <b>overrides</b> the default known method sets completely; it does
94-
* not supplement it.
90+
* <p><b>Note:</b> This <b>overrides</b> defaults completely; it does not supplement them.
9591
*
96-
* @param knownMethods A set of recognized HTTP request methods.
92+
* @param knownMethods HTTP request methods to recognize.
9793
* @see HttpClientAttributesExtractorBuilder#setKnownMethods(Collection)
9894
*/
9995
@CanIgnoreReturnValue
@@ -102,17 +98,15 @@ public ArmeriaClientTelemetryBuilder setKnownMethods(Collection<String> knownMet
10298
return this;
10399
}
104100

105-
/**
106-
* Sets a customizer that receives the default {@link SpanNameExtractor} and returns a customized
107-
* one.
108-
*/
101+
/** Customizes the {@link SpanNameExtractor} by transforming the default instance. */
109102
@CanIgnoreReturnValue
110103
public ArmeriaClientTelemetryBuilder setSpanNameExtractorCustomizer(
111104
UnaryOperator<SpanNameExtractor<ClientRequestContext>> spanNameExtractorCustomizer) {
112105
builder.setSpanNameExtractorCustomizer(spanNameExtractorCustomizer);
113106
return this;
114107
}
115108

109+
/** Returns a new instance with the configured settings. */
116110
public ArmeriaClientTelemetry build() {
117111
return new ArmeriaClientTelemetry(builder.build());
118112
}

instrumentation/armeria/armeria-1.3/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_3/ArmeriaServerTelemetry.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515
/** Entrypoint for instrumenting Armeria services. */
1616
public final class ArmeriaServerTelemetry {
1717

18-
/**
19-
* Returns a new {@link ArmeriaServerTelemetry} configured with the given {@link OpenTelemetry}.
20-
*/
18+
/** Returns a new instance configured with the given {@link OpenTelemetry} instance. */
2119
public static ArmeriaServerTelemetry create(OpenTelemetry openTelemetry) {
2220
return builder(openTelemetry).build();
2321
}
2422

23+
/** Returns a builder configured with the given {@link OpenTelemetry} instance. */
2524
public static ArmeriaServerTelemetryBuilder builder(OpenTelemetry openTelemetry) {
2625
return new ArmeriaServerTelemetryBuilder(openTelemetry);
2726
}
@@ -32,10 +31,7 @@ public static ArmeriaServerTelemetryBuilder builder(OpenTelemetry openTelemetry)
3231
this.instrumenter = instrumenter;
3332
}
3433

35-
/**
36-
* Returns a new {@link HttpService} decorator for use with methods like {@link
37-
* HttpService#decorate(Function)}.
38-
*/
34+
/** Returns a decorator for instrumenting Armeria services. */
3935
public Function<? super HttpService, ? extends HttpService> newDecorator() {
4036
return service -> new OpenTelemetryService(service, instrumenter);
4137
}

instrumentation/armeria/armeria-1.3/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_3/ArmeriaServerTelemetryBuilder.java

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,7 @@ public final class ArmeriaServerTelemetryBuilder {
3434
builder = ArmeriaInstrumenterBuilderFactory.getServerBuilder(openTelemetry);
3535
}
3636

37-
/**
38-
* Sets a customizer that receives the default {@link SpanStatusExtractor} and returns a
39-
* customized one.
40-
*/
37+
/** Customizes the {@link SpanStatusExtractor} by transforming the default instance. */
4138
@CanIgnoreReturnValue
4239
public ArmeriaServerTelemetryBuilder setSpanStatusExtractorCustomizer(
4340
UnaryOperator<SpanStatusExtractor<ServiceRequestContext, RequestLog>>
@@ -47,8 +44,8 @@ public ArmeriaServerTelemetryBuilder setSpanStatusExtractorCustomizer(
4744
}
4845

4946
/**
50-
* Adds an extra {@link AttributesExtractor} to invoke to set attributes to instrumented items.
51-
* The {@link AttributesExtractor} will be executed after all default extractors.
47+
* Adds an {@link AttributesExtractor} to extract attributes from requests and responses. Executed
48+
* after all default extractors.
5249
*/
5350
@CanIgnoreReturnValue
5451
public ArmeriaServerTelemetryBuilder addAttributesExtractor(
@@ -58,9 +55,9 @@ public ArmeriaServerTelemetryBuilder addAttributesExtractor(
5855
}
5956

6057
/**
61-
* Configures the HTTP server request headers that will be captured as span attributes.
58+
* Configures HTTP request headers to capture as span attributes.
6259
*
63-
* @param requestHeaders A list of HTTP header names.
60+
* @param requestHeaders HTTP header names to capture.
6461
*/
6562
@CanIgnoreReturnValue
6663
public ArmeriaServerTelemetryBuilder setCapturedRequestHeaders(
@@ -70,9 +67,9 @@ public ArmeriaServerTelemetryBuilder setCapturedRequestHeaders(
7067
}
7168

7269
/**
73-
* Configures the HTTP server response headers that will be captured as span attributes.
70+
* Configures HTTP response headers to capture as span attributes.
7471
*
75-
* @param responseHeaders A list of HTTP header names.
72+
* @param responseHeaders HTTP header names to capture.
7673
*/
7774
@CanIgnoreReturnValue
7875
public ArmeriaServerTelemetryBuilder setCapturedResponseHeaders(
@@ -82,16 +79,15 @@ public ArmeriaServerTelemetryBuilder setCapturedResponseHeaders(
8279
}
8380

8481
/**
85-
* Configures the instrumentation to recognize an alternative set of HTTP request methods.
82+
* Configures recognized HTTP request methods.
8683
*
87-
* <p>By default, this instrumentation defines "known" methods as the ones listed in <a
88-
* href="https://www.rfc-editor.org/rfc/rfc9110.html#name-methods">RFC9110</a> and the PATCH
89-
* method defined in <a href="https://www.rfc-editor.org/rfc/rfc5789.html">RFC5789</a>.
84+
* <p>By default, recognizes methods from <a
85+
* href="https://www.rfc-editor.org/rfc/rfc9110.html#name-methods">RFC9110</a> and PATCH from <a
86+
* href="https://www.rfc-editor.org/rfc/rfc5789.html">RFC5789</a>.
9087
*
91-
* <p>Note: calling this method <b>overrides</b> the default known method sets completely; it does
92-
* not supplement it.
88+
* <p><b>Note:</b> This <b>overrides</b> defaults completely; it does not supplement them.
9389
*
94-
* @param knownMethods A set of recognized HTTP request methods.
90+
* @param knownMethods HTTP request methods to recognize.
9591
* @see HttpServerAttributesExtractorBuilder#setKnownMethods(Collection)
9692
*/
9793
@CanIgnoreReturnValue
@@ -100,17 +96,15 @@ public ArmeriaServerTelemetryBuilder setKnownMethods(Collection<String> knownMet
10096
return this;
10197
}
10298

103-
/**
104-
* Sets a customizer that receives the default {@link SpanNameExtractor} and returns a customized
105-
* one.
106-
*/
99+
/** Customizes the {@link SpanNameExtractor} by transforming the default instance. */
107100
@CanIgnoreReturnValue
108101
public ArmeriaServerTelemetryBuilder setSpanNameExtractorCustomizer(
109102
UnaryOperator<SpanNameExtractor<ServiceRequestContext>> spanNameExtractorCustomizer) {
110103
builder.setSpanNameExtractorCustomizer(spanNameExtractorCustomizer);
111104
return this;
112105
}
113106

107+
/** Returns a new instance with the configured settings. */
114108
public ArmeriaServerTelemetry build() {
115109
return new ArmeriaServerTelemetry(builder.build());
116110
}

0 commit comments

Comments
 (0)