Merged
Conversation
- Add re-exports from @zeix/cause-effect: createSignal, unown, untrack, isObjectOfType, SKIP_EQUALITY - Add error classes ReadonlySignalError, RequiredOwnerError, UnsetSignalValueError - Upgrade cause-effect to 0.18.5 to fix scope disposal in re-runnable effects - Update examples (form-checkbox, form-radiogroup, form-spinbutton) to support controlled usage - Update CHANGELOG/docs to reflect the new API surface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
@zeix/cause-effect:createSignal,unown,untrack,isObjectOfType,SKIP_EQUALITY, and error classesReadonlySignalError,RequiredOwnerError,UnsetSignalValueError— previously omitted from Le Truc's public API surface.Changed
@zeix/cause-effectupgraded to0.18.5: Addsunown()and fixes a scope disposal bug in components connected inside re-runnable effects (see Fixed below).form-checkbox,form-radiogroup, andform-spinbuttonexamples updated: All three examples now support controlled component usage, accepting externally managed state in addition to their built-in uncontrolled behaviour.Fixed
connectedCallbackfires inside a re-runnable effect:createScopeinside a reactive effect (e.g. a list-sync effect) registered its dispose on that effect's cleanup list. When the effect re-ran — for example because aMutationObserverfired — it disposed all child scopes including those of already-connected components, silently removing their live event listeners and reactive subscriptions. Fixed by wrapping theconnectedCallbackbody inunown(), detaching each component's scope from the surrounding effect's ownership tree so effect re-runs no longer dispose it.