Debug Actor Work: d_a_andsw - d_a_obj_ito by carter-ktb21 · Pull Request #2761 · zeldaret/tp

carter-ktb21 · 2025-10-29T13:59:40Z

No description provided.

decomp-dev · 2025-10-29T14:04:15Z

Report for Shield (`2f2f37a` - `c48a4ad`)

📈 Matched code: 6.50% (+0.00%, +396 bytes)

✅ 3 new matches

Unit	Function	Bytes	Before	After
`d_a_door_dbdoor00/d/actor/d_a_door_dbdoor00`	`nodeCallBack(J3DJoint*, int)`	+3	99.08%	100.00%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::Create()`	+1	99.29%	100.00%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::ExecuteType1()`	+1	99.60%	100.00%

📈 14 improvements in unmatched functions

Unit	Function	Bytes	Before	After
`d_a_door_shutter/d/actor/d_a_door_shutter`	`daDoor20_c::makeEventId()`	+54	67.10%	72.10%
`d_a_kytag00/d/actor/d_a_kytag00`	`wether_tag_efect_move(kytag00_class*)`	+14	81.49%	82.16%
`d_a_door_shutter/d/actor/d_a_door_shutter`	`daDoor20_c::openInit_0()`	+11	59.78%	60.98%
`d_a_obj_carry/d/actor/d_a_obj_carry`	`daObjCarry_c::CreateInit_bokkuri()`	+3	19.66%	19.98%
`d_a_obj_carry/d/actor/d_a_obj_carry`	`daObjCarry_c::obj_break(bool, bool, bool)`	+2	73.75%	74.30%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::CreateHeap()`	0	99.74%	99.98%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::setParticle()`	0	91.73%	91.77%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::orderWait_tri()`	0	45.81%	45.82%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::orderWait_cyl()`	0	45.20%	45.21%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::orderWait_spec()`	0	48.61%	48.62%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::Execute(float(**)[3][4])`	0	52.83%	52.98%
`d_a_door_knob00/d/actor/d_a_door_knob00`	`daKnob20_c::CreateHeap()`	0	62.28%	62.30%
`d_a_ep/d/actor/d_a_ep`	`daEp_Create(fopAc_ac_c*)`	0	50.90%	50.91%
`d_a_obj_carry/d/actor/d_a_obj_carry`	`daObjCarry_c::mode_proc_wait()`	0	30.13%	30.20%

📉 6 regressions in unmatched functions

Unit	Function	Bytes	Before	After
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::spec_data_c::Set(void*)`	-59	76.63%	67.32%
`d_a_door_dbdoor00/d/actor/d_a_door_dbdoor00`	`daDbDoor00_c::CreateHeap()`	-58	74.95%	63.33%
`d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff`	`obj_brakeeff_1(obj_brakeeff_class*)`	-51	92.12%	82.99%
`d_a_obj_carry/d/actor/d_a_obj_carry`	`daObjCarry_c::CreateInit_ironball()`	-50	43.17%	30.00%
`d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff`	`daObj_Brakeeff_Execute(obj_brakeeff_class*)`	-8	84.96%	81.47%
`framework/d/d_com_static`	`daObjCarry_c::chkSttsFlag(int, unsigned char)`	-3	81.43%	68.57%

Report for GZ2J01 (`2f2f37a` - `c48a4ad`)

[!] Report not found. Did the build succeed?

Report for RZDE01_00 (`2f2f37a` - `c48a4ad`)

📈 Matched code: 34.25% (+0.03%, +3000 bytes)

✅ 14 new matches

Unit	Function	Bytes	Before	After
`d_a_obj_burnbox/d/actor/d_a_obj_burnbox`	`daObjBurnBox_c::create1st()`	+22	86.03%	100.00%
`d_a_door_dbdoor00/d/actor/d_a_door_dbdoor00`	`J3DModelData::getJointNodePointer(unsigned short) const`	+16	0.00%	100.00%
`d_a_kytag00/d/actor/d_a_kytag00`	`wether_tag_efect_move(kytag00_class*)`	+16	99.15%	100.00%
`d_a_obj_carry/d/actor/d_a_obj_carry`	`daObjCarry_c::initBaseMtx()`	+8	92.00%	100.00%
`framework/d/d_com_static`	`daObjCarry_c::chkSttsFlag(int, unsigned char)`	+5	82.50%	100.00%
`d_a_door_shutter/d/actor/d_a_door_shutter`	`dDoor_stop_c::create(daDoor20_c*)`	+4	95.00%	100.00%
`d_a_door_dbdoor00/d/actor/d_a_door_dbdoor00`	`nodeCallBack(J3DJoint*, int)`	+3	99.08%	100.00%
`d_a_obj_carry/d/actor/d_a_obj_carry`	`daObjCarry_c::CreateInit_ironball()`	+3	98.89%	100.00%
`d_a_obj_carry/d/actor/d_a_obj_carry`	`daObjCarry_c::obj_break(bool, bool, bool)`	+3	99.20%	100.00%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::Create()`	+1	99.29%	100.00%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::CreateHeap()`	+1	99.76%	100.00%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::setColCommon()`	+1	99.72%	100.00%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::ExecuteType1()`	+1	99.60%	100.00%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::Execute(float(**)[3][4])`	+1	99.79%	100.00%

💔 1 broken match

Unit	Function	Bytes	Before	After
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::spec_data_c::Set(void*)`	-34	100.00%	94.21%

📈 9 improvements in unmatched functions

Unit	Function	Bytes	Before	After
`d_a_passer_mng/d/actor/d_a_passer_mng`	`daPasserMng_c::getPasserParam()`	+2639	35.11%	99.60%
`d_a_door_dbdoor00/d/actor/d_a_door_dbdoor00`	`daDbDoor00_c::CreateHeap()`	+59	84.97%	99.86%
`d_a_ep/d/actor/d_a_ep`	`daEp_Execute(ep_class*)`	+12	86.28%	86.51%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::setParticle()`	0	89.81%	89.86%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::orderWait_tri()`	0	99.98%	99.99%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::orderWait_cyl()`	0	99.97%	99.99%
`d_a_bg_obj/d/actor/d_a_bg_obj`	`daBgObj_c::orderWait_spec()`	0	99.96%	99.99%
`d_a_door_knob00/d/actor/d_a_door_knob00`	`daKnob20_c::CreateHeap()`	0	99.88%	99.92%
`d_a_ep/d/actor/d_a_ep`	`daEp_Create(fopAc_ac_c*)`	0	95.36%	95.37%

📉 2 regressions in unmatched functions

Unit	Function	Bytes	Before	After
`d_a_obj_brakeeff/d/actor/d_a_obj_brakeeff`	`daObj_Brakeeff_Execute(obj_brakeeff_class*)`	-6	23.47%	22.67%
`d_a_obj_carry/d/actor/d_a_obj_carry`	`daObjCarry_c::mode_proc_wait()`	-1	90.75%	90.56%

Report for GZ2E01 (`2f2f37a` - `c48a4ad`)

No changes

Report for ShieldD (`2f2f37a` - `c48a4ad`)

[!] Report not found. Did the build succeed?

Report for GZ2P01 (`2f2f37a` - `c48a4ad`)

[!] Report not found. Did the build succeed?

TakaRikka · 2025-10-30T23:45:36Z

src/d/actor/d_a_bg_obj.cpp

+// static const char* dummy() {
+//     return "spec.dat";
+// }


if this isnt needed then it can be removed

TakaRikka · 2025-10-30T23:46:45Z

include/d/actor/d_a_bg_obj.h

+    /* 0x5A8 */ J3DModel* mpModelMtx[2][2];
+    /* 0x5B8 */ mDoExt_btkAnm* mpBtkAnmMtx[2][2];
+    /* 0x5C8 */ mDoExt_brkAnm* mpBrkAnmMtx[2][2];


i dont really like the mtx naming here as it implies its a Mtx type when its not

TakaRikka · 2025-10-30T23:48:11Z

src/d/actor/d_a_door_dbdoor00.cpp

+        u8 frontOption = door_param2_c::getFrontOption(this);
+        u8 backOption = door_param2_c::getBackOption(this);
+        if (frontOption != 0) {
+            OS_REPORT_ERROR("両開き押しドア：表のオプション指定があります！<%d>\n", frontOption); // Double-opening push door: There are options specified on the front! <%d>


in general i prefer these translation comments on the line above so that we dont get these super long lines

TakaRikka · 2025-10-30T23:51:01Z

src/d/actor/d_a_door_shutter.cpp

+                dComIfGs_onSwitch(swBit, 0xFFFFFFFF);
+                dComIfGp_setItemKeyNumCount(0xFFFFFFFF);


TakaRikka · 2025-10-31T00:00:03Z

src/d/actor/d_a_hitobj.cpp

-        i_this->field_0x572--;
-        i_this->field_0x5b0.SetC(i_this->current.pos);
-        dComIfG_Ccsp()->Set(&i_this->field_0x5b0);
+    fopAc_ac_c* a_this = (fopAc_ac_c*)i_this;


in general we're using actor instead of a_this nowadays as it seems to be closer to what they did originally

TakaRikka · 2025-10-31T00:05:53Z

src/d/actor/d_a_passer_mng.cpp

+daPasserMng_Attr_c& daPasserMng_Attr_c::operator=(const daPasserMng_Attr_c& attr) {
+    appearance_interval = attr.appearance_interval;
+    npc_type = attr.npc_type;
+    return *this;
+}


does this need to exist or can it be compiler generated?

TakaRikka · 2025-10-31T00:08:21Z

src/d/d_a_obj.cpp

 #include "SSystem/SComponent/c_math.h"
 #include "d/actor/d_a_player.h"
 #include "d/d_com_inf_game.h"
+#include "dol2asm.h"


if macros from here are needed to match, i'd prefer writing the expanded form out and adding a fake match since ideally we want to remove all dol2asm or dtk specific references in source code

TakaRikka · 2025-10-31T00:08:40Z

src/d/d_a_obj.cpp

+    }
+
+    if (i >= 16) {
+        OS_REPORT_ERROR("汎用オブジェノードバッファがパンク(%s %d)\n", "d_a_obj.cpp", 872); // Generic object node buffer full (%s %d)


TakaRikka · 2025-11-19T20:44:11Z

in addition to the other cleanup comments that need to be addressed, it'd be good to try to fix that broken match on wii since it was 100% before the changes here

carter-ktb21 and others added 19 commits October 23, 2025 20:22

initial passer_mng work

69242e2

passer_mng debug work

289466d

d_a_andsw work

f12980b

d_a_bg_obj work

1691924

d_a_dmidna work

f07d779

d_a_door_dbdoor00 work

8337021

d_a_door_shutter initial work

183526e

d_a_door_shutter work

e4b876d

d_a_door_spiral initial work

ebf09ad

d_a_door_spiral work

0d9b8fc

d_a_dshutter work

9279e11

d_a_ep work

0881445

d_a_hitobj work

0041866

d_a_kytag00 work

139e094

d_a_obj_brakeeff work

cf576fd

d_a_obj_burnbox work

3531ae7

d_a_obj_carry init work

b0779da

d_a_obj_carry work

62e9892

d_a_obj_ito work

063242a

TakaRikka reviewed Oct 31, 2025

View reviewed changes

carter-ktb21 marked this pull request as draft November 10, 2025 15:03

carter-ktb21 force-pushed the debug_work branch from 09ae7e4 to 063242a Compare November 19, 2025 19:50

carter-ktb21 added 3 commits November 19, 2025 14:55

Merge branch 'main' of https://github.com/zeldaret/tp into debug_work

02743ae

merge fix

8952066

PR cleanup

d6036f2

carter-ktb21 marked this pull request as ready for review November 19, 2025 20:13

carter-ktb21 and others added 2 commits November 20, 2025 08:02

fixed naming

ef5ccba

Merge branch 'main' into debug_work

c48a4ad

ItsNiklas mentioned this pull request Dec 2, 2025

d_a_obj_brakeeff debug equivalent #2906

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Debug Actor Work: d_a_andsw - d_a_obj_ito#2761

Debug Actor Work: d_a_andsw - d_a_obj_ito#2761
carter-ktb21 wants to merge 24 commits intozeldaret:mainfrom
carter-ktb21:debug_work

carter-ktb21 commented Oct 29, 2025

Uh oh!

decomp-dev bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

TakaRikka Oct 30, 2025

Uh oh!

TakaRikka Oct 30, 2025

Uh oh!

TakaRikka Oct 30, 2025

Uh oh!

TakaRikka Oct 30, 2025

Uh oh!

TakaRikka Oct 31, 2025

Uh oh!

TakaRikka Oct 31, 2025

Uh oh!

TakaRikka Oct 31, 2025

Uh oh!

TakaRikka Oct 31, 2025

Uh oh!

TakaRikka commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		dComIfGs_onSwitch(swBit, 0xFFFFFFFF);
		dComIfGp_setItemKeyNumCount(0xFFFFFFFF);

Conversation

carter-ktb21 commented Oct 29, 2025

Uh oh!

decomp-dev bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for Shield (2f2f37a - c48a4ad)

Report for GZ2J01 (2f2f37a - c48a4ad)

Report for RZDE01_00 (2f2f37a - c48a4ad)

Report for GZ2E01 (2f2f37a - c48a4ad)

No changes

Report for ShieldD (2f2f37a - c48a4ad)

Report for GZ2P01 (2f2f37a - c48a4ad)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TakaRikka commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

decomp-dev bot commented Oct 29, 2025 •

edited

Loading

Report for Shield (`2f2f37a` - `c48a4ad`)

Report for GZ2J01 (`2f2f37a` - `c48a4ad`)

Report for RZDE01_00 (`2f2f37a` - `c48a4ad`)

Report for GZ2E01 (`2f2f37a` - `c48a4ad`)

Report for ShieldD (`2f2f37a` - `c48a4ad`)

Report for GZ2P01 (`2f2f37a` - `c48a4ad`)