d_a_obj_mkie - matching retail#931
Merged
LagoLunatic merged 2 commits intozeldaret:mainfrom Feb 15, 2026
Merged
Conversation
Report for GZLP01 (ca9481d - 9b96996)📈 Matched code: 56.34% (+0.07%, +5840 bytes) ✅ 62 new matches
...and 32 more new matches Report for GZLE01 (ca9481d - 9b96996)📈 Matched code: 58.07% (+0.07%, +5840 bytes) ✅ 62 new matches
...and 32 more new matches Report for D44J01 (ca9481d - 9b96996)📈 Matched code: 45.65% (+0.05%, +3724 bytes) ✅ 55 new matches
...and 25 more new matches 📈 7 improvements in unmatched items
Report for GZLJ01 (ca9481d - 9b96996)📈 Matched code: 56.39% (+0.07%, +5832 bytes) ✅ 62 new matches
...and 32 more new matches |
LagoLunatic
reviewed
Feb 14, 2026
| /* 000011FC-00001338 .text mode_demo__Q29daObjMkie5Act_cFv */ | ||
| void daObjMkie::Act_c::mode_demo() { | ||
| /* Nonmatching */ | ||
| if (mState > 0 && (mState -= 1, mState == 0)) { |
Collaborator
There was a problem hiding this comment.
Can avoid the comma operator like this
Suggested change
| if (mState > 0 && (mState -= 1, mState == 0)) { | |
| if (mState > 0 && --mState == 0) { |
Contributor
Author
There was a problem hiding this comment.
This changes completion of that method. Can't do the --, have to keep the comma operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing #420
Matching mkie for retail.
Stone statue in Earth temple that can be shot with light to vanish.