Merged
Conversation
…ember layout in `daBoomerang_c`.
…s for structure validation.
…nd update function signatures.
…L` and adjust related calls.
…er variables, and adjust structure layout in `d_a_boomerang.h`.
…r_top` and `l_blur_root`.
…field, update structure layout in `d_a_boomerang.h`.
…, modify array structure to use 2D layout, and adjust declarations in `d_a_boomerang.h`.
…ription, attribute format lists, and texture handling logic.
…g logic for modifying `field_0xF4` values.
…ent animation logic, replace `field_0xF4` with `arr_0xF4`, add `arr_0xF9`, and update structure in `d_a_boomerang.h`.
…hods; update image data logic in `d_a_boomerang.cpp` and `d_a_boomerang.h`.
… initialize `arr_0xF4` and reset `targetFlags`.
….cpp` and `d_a_boomerang.h`
…pdate structure fields, and adjust logic in `setSight`, `play`, and related methods.
…scriptor/attribute format lists, texture handling, and sight rendering logic.
…on to `GX_S8` and texture to `GX_U8`.
…l_sightMatDL` and `l_sightDL__d_a_boomerang`
…me checks to determine maximum flight distance.
…ng targeting logic, rename variables for clarity, update array structures, and adjust control flow.
…late angles, update position/rotation, handle water effects, and refine collision detection. Adjust structure fields in `d_a_boomerang.h`.
…, adjust distance-based normalization, and refine boomerang return handling.
…_DECL(32)` in `d_a_boomerang.cpp` for consistent memory alignment.
…th `yRotPerStep` variable for clarity and maintainability.
…`field_0xF2D` to `unused_0xF2D` for improved clarity.
…_c::SEGMENTS_PER_STEP` for improved readability and maintainability.
…tParam` for consistency with actor parameter retrieval methods.
…d values for improved readability and maintainability.
…mproved clarity.
… for consistency with actor parameter setting methods.
…or improved readability and maintainability.
…` for consistency.
…ated variables and methods to lock-related for improved clarity and consistency.
…ng.cpp` to simplify and remove redundant casts.
Report for GZLJ01 (60b0d94 - ae23b70)📈 Matched code: 56.97% (+0.14%, +10656 bytes) ✅ 42 new matches
...and 12 more new matches Report for D44J01 (60b0d94 - ae23b70)📈 Matched code: 46.20% (+0.13%, +9816 bytes) ✅ 41 new matches
...and 11 more new matches 📈 1 improvement in an unmatched item
Report for GZLE01 (60b0d94 - ae23b70)📈 Matched code: 58.68% (+0.14%, +10688 bytes) ✅ 42 new matches
...and 12 more new matches Report for GZLP01 (60b0d94 - ae23b70)📈 Matched code: 56.91% (+0.14%, +10688 bytes) ✅ 42 new matches
...and 12 more new matches |
LagoLunatic
reviewed
Mar 3, 2026
…icle_setP1` for improved clarity and maintainability.
…s in `d_a_boomerang.cpp` for consistency.
…ith `VERSION_SELECT` for improved maintainability.
…oomerang.cpp` for consistency.
Collaborator
|
Looks good. Any reason it's marked as a draft? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #574