feat: Enable original extensions panel on hide-unified-extensions-button: false #11335
Conversation
dosubot
bot
added
size:L
There was a problem hiding this comment.
Instead of choosing what panel should be used every time, we could just revert these changes if the preference is off:
desktop/src/browser/base/content/browser-addons-js.patch
Lines 44 to 52 in 0899621
Or at least simply override it? gUnifiedExtensions._panel = ...
Yes, that's true. Effectively that's what |
| notInPanel || | ||
| document.querySelector("#unified-extensions-area > :first-child") | ||
| - ?.id === widgetId | ||
| + ?.id === widgetIdz |
There was a problem hiding this comment.
Whoops, just an extra character that slipped in. Good catch.
Commit: 31f4d4e
| - let template = document.getElementById( | ||
| - "unified-extensions-panel-template" | ||
| - ); | ||
| - template.replaceWith(template.content); |
There was a problem hiding this comment.
Instead of removing, you should just see if the preference is enabled and then do what the patch is originally doing or firefox's addon functionality.
https://github.com/zen-browser/desktop/pull/11335/files#r2545668861
mr-cheffy
left a comment
mr-cheffy
left a comment
There was a problem hiding this comment.
I'll give it a test try later today, looks good overall
| // Partial implementation of "get panel()" from engine/browser/base/content/browser-addons.js | ||
| const { BrowserAddonUI, CustomizableUI } = this.window; | ||
|
|
||
| CustomizableUI.registerPanelNode(customizationArea, CustomizableUI.AREA_ADDONS); |
There was a problem hiding this comment.
Not really sure about this, as doing re-implementations might be hard to sync when updating upstream. Maybe some unit tests would help this issue?
There was a problem hiding this comment.
Where do unit tests live? I could give it a shot
There was a problem hiding this comment.
You can give it a try here: https://github.com/zen-browser/desktop/tree/dev/src/zen/tests
Making a new directory like "control-panel" for example
2 participants
Summary
Updated
ZenSiteDataPanel.sys.mjsto support multiple panels and pass relevant objects tobrowser-addons.jsPatched
browser-addons.jsto accept panel objectsPatched
navigator-toolbox.jsto get panel objects fromwindow.gZenSiteDataPanelUpdated
zen-single-components.cssto conditionally hide extensions on unified panelScreenshots
hide-unified-extensions-button: truehide-unified-extensions-button: falseNotes
hide-unified-extensions-buttondoes require a browser restart to fully take effect and swich over. This is because the list of extensions are added on browser initialization. It does not appearbrowser/components/customizableui/CustomizableUI.sys.mjsis able to natively support adding and removing extensions from multiple areas