Skip to content

fix: resolve copy URL with shortcut return about:blank during pending navigations #12521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
phannawich wants to merge 14 commits into
base: dev
Choose a base branch
from
Draft

fix: resolve copy URL with shortcut return about:blank during pending navigations #12521

Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e12746d
fix: resolve copy URL delay during pending navigations
phannawich Feb 22, 2026
fd62f70
Fix the copy url shortcut getting about:blank
phannawich Feb 26, 2026
dc751c3
Implement copy URL as markdown to handle the same way as copyCurrentU…
phannawich Feb 26, 2026
ca1eed6
Delete extra code that already got reject in PR
phannawich Feb 26, 2026
99aedaa
Fix zenStrippedURI return about:blank
phannawich Mar 1, 2026
0a1590f
Merge pull request #1 from phannawich/fix-copy-url-shortcut
phannawich Mar 1, 2026
e1a72e9
revert ZenCommonUtils to the dev branch
phannawich Mar 1, 2026
7a1e283
Delete src/zen/common/modules/ZenCommonUtils.mjs
phannawich Mar 1, 2026
37ffc2c
Revert "Delete src/zen/common/modules/ZenCommonUtils.mjs"
phannawich Mar 1, 2026
f5fc461
Discard changes to src/zen/common/modules/ZenCommonUtils.mjs
mr-cheffy Mar 1, 2026
f62c306
Merge branch 'dev' into phannawich/fix-copy-url-shortcut
phannawich Mar 7, 2026
1ec6d33
Delete comment as suggested by the maintainer
phannawich Mar 8, 2026
e6d131f
Fix the corrupt patch
phannawich Mar 8, 2026
93a4433
Delete the unrelated part in the patch
phannawich Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions src/zen/common/modules/ZenCommonUtils.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,22 @@ export class nsZenPreloadedFeature {

window.gZenCommonActions = {
copyCurrentURLToClipboard() {

const activeBrowser = gBrowser.selectedBrowser;
const [currentUrl, ClipboardHelper] = gURLBar.zenStrippedURI;
const displaySpec = currentUrl.displaySpec;

let displaySpec = activeBrowser.userTypedValue ||
gURLBar.untrimmedValue ||
(activeBrowser.currentURI ? activeBrowser.currentURI.spec : "") ||
currentUrl.displaySpec;

if (displaySpec === "about:blank" || displaySpec === "") {
Copy link
Copy Markdown
Member

@mr-cheffy mr-cheffy Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you copy the tab's label tough? This seems like a hacky solution to the real issue

Copy link
Copy Markdown
Author

@phannawich phannawich Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found out the the tab's label get the label even before the URL bar and website finish loading.
And it can be used to put in the URL bar to search for the website

What do you recommend me to approach this problem?

  1. Delete the if check block entirely and let it fall back to about:blank when the browser cannot grab any URL from all the case above?
  2. Any ideas on your side?

Copy link
Copy Markdown
Member

@mr-cheffy mr-cheffy Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I have no idea yet... Let me investigate a bit and ill come back to you because this is a complex issue, even if it doesn't look like one

Copy link
Copy Markdown
Member

@mr-cheffy mr-cheffy Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth to checkout what firefox is doing here:

https://searchfox.org/firefox-main/source/browser/components/customizableui/CustomizableWidgets.sys.mjs#524

const tabLabel = gBrowser.selectedTab.label;
if (tabLabel && tabLabel !== "New Tab") {
displaySpec = tabLabel;
}
}

ClipboardHelper.copyString(displaySpec);
let button;
/* eslint-disable mozilla/valid-services */
Expand All @@ -111,9 +125,23 @@ window.gZenCommonActions = {
},

copyCurrentURLAsMarkdownToClipboard() {
const activeBrowser = gBrowser.selectedBrowser;
const [currentUrl, ClipboardHelper] = gURLBar.zenStrippedURI;
const tabTitle = gBrowser.selectedTab.label;
const markdownLink = `[${tabTitle}](${currentUrl.displaySpec})`;

let displaySpec = activeBrowser.userTypedValue ||
gURLBar.untrimmedValue ||
(activeBrowser.currentURI ? activeBrowser.currentURI.spec : "") ||
currentUrl.displaySpec;

if (displaySpec === "about:blank" || displaySpec === "") {
const tabLabel = gBrowser.selectedTab.label;
if (tabLabel && tabLabel !== "New Tab") {
displaySpec = tabLabel;
}
}

const tabTitle = gBrowser.selectedTab.label || displaySpec;
const markdownLink = `[${tabTitle}](${displaySpec})`;
ClipboardHelper.copyString(markdownLink);
gZenUIManager.showToast("zen-copy-current-url-confirmation", { timeout: 3000 });
},
Expand All @@ -140,4 +168,4 @@ window.gZenCommonActions = {
const tab = gBrowser.selectedTab;
return Boolean(tab.owner && !tab.pinned && !tab.hasAttribute("zen-empty-tab"));
},
};
};