-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Shortcuts for Next/Prev Tab Navigation #3599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great! But we'll need to disable the other shortcuts.. Ill do that when I get home and ill merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update LATEST_KBS_VERSION
?
Signed-off-by: normaltaro <[email protected]>
done |
do i move |
Any updates on this? 👀 |
This ended up being not as easy as it looks... Im still investigating |
If anyone wants a workaround to get this feature you can try out my hotkeys config in the meantime which works good for me: https://github.com/KorigamiK/zen-conf/blob/main/chrome/JS/hotkeys.uc.js |
I wasn't able to make this work but I used karabiner elements complex modifications instead to bind the keys i wanted to ctrl+tab and ctrl+shift+tab
|
Ah, nice although it's macos only |
@KorigamiK |
No, you don't need to enable anything just place the files in the right locations. then you paste my script https://github.com/KorigamiK/zen-conf/blob/main/chrome/JS/hotkeys.uc.js into |
Any updates? |
These keybinds were initially here when I first discovered Zen many months ago, what caused the regression and the difficult re-implementation? |
I'm also curious to know what's the issue here, this seemed like a simple change and at one point it worked fine, until it got removed. |
Up what we need to make this PR merged @mr-cheffy ? |
Been following this issue quite closely for a while now. Not having this really breaks navigation with keyboard, especially once one includes PDF-viewer tabs, which Vimium can't navigate among. What contributions are currently missing @mr-cheffy ? |
I must +1 this feature I need to be able to remap Next/Previous tab cycling. The existing shortcuts:
|
I have not been using this browser since many months. I am glad and a bit overwhelmed to see such enthusiasm from so many people who are in support of this simple, yet extremely handy feature for keyboard-first users. I am not a legit programmer, though I wish to be. From my understanding this browser code is a framework of patches onto firefox source code, like librewolf. I once browsed the firefox source code for I guessed that it might work with zen browsers codebase since I felt it lived in the same 'source-build scope' and I tried it. It worked ok back then and I made this request. Another guy before me also made a request for this feature, and it wasnt merged. I cant recall why. I thought mine would be since the browser was in a very alpha state and changes I made were too tiny, not interfering with any development code. I should have referenced it when I posted this. I think this wont be merged since the developers of the browser probably want to use their own 'framework' intead of this hacky one liner approach which directly calls a firefox internal browser function. I do know a bit more programming now so I could try again to make a more 'real' patch with more consideration to workspace and split views behavior. I will keep this request open since many people support it. Anyone is free to work on this feature and should not wait for me or this request. I think should have sent this earlier but I am not too familiar with open source (or good at life in general). I am sorry. |
This should be moved into this newly created PR: #9441 The issue is mostly about how we should handle shortcuts and their precedence. It would be annoying if you tried to ctrl+tab and sites like github blocked that logic, right? So instead of using the firefox key management, we should be doing our own one. This is what firefox has done and why its hard coded. This however will be fixed very soon by disabling firefox's implementation and adding our own one that supports dynamic shortcuts. |
Added 2 shortcuts for tab navigation.
Using extensions such as
Tridactyl
orVimium
to do this stops working on protected pages such as New Tab, Settings, etc and breaks the flow. But this keyboard shortcut will work on any opened tab. It is a better user experience to those who really like the keyboard.Relevant Issue: #1678
I know English. I have submitted the relevant PR to the l10n repo: zen-browser/l10n-packs#110