Skip to content

fix: Allow scrolling on edge of the window #8461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: dev
Choose a base branch
from
Open

fix: Allow scrolling on edge of the window #8461

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
87e491d
initial trial of edge scrolling
rstanuwijaya May 20, 2025
e5a30c1
Try to change implementation into fake mouse event but failed
rstanuwijaya May 20, 2025
cdb8608
Reverted into scroll
rstanuwijaya May 20, 2025
f932117
Activate adjacent browser
rstanuwijaya May 20, 2025
73bde70
Try to synthesize mouse event again
rstanuwijaya May 20, 2025
a4ad405
Synthesize mouse click event
rstanuwijaya May 20, 2025
916079b
Merge branch 'dev' into fix-edge-scrolling
mr-cheffy May 20, 2025
2addbee
Merge branch 'dev' into fix-edge-scrolling
mr-cheffy May 21, 2025
416db95
Working actor implementation
rstanuwijaya May 21, 2025
67742d9
Refine code
rstanuwijaya May 21, 2025
25bc7bd
Add prefs zen.edgescroll.enabled
rstanuwijaya May 21, 2025
ae91fc4
fix: Change the mousemove and mouseup listener to window
rstanuwijaya May 21, 2025
84aa004
fix: Add restart prompt when updating edgescroll prefs
rstanuwijaya May 21, 2025
ee0a312
fix: Enable edgescroll on about:* pages
rstanuwijaya May 21, 2025
892c6a8
fix: Only display zen-edge-scroll-trigger when the sidebar is on the …
rstanuwijaya May 21, 2025
8868a4c
fix: Increase offset to 2 pixels
rstanuwijaya May 21, 2025
ebea8f6
chore: Remove logging
rstanuwijaya May 21, 2025
c100068
style: Lint code
rstanuwijaya May 22, 2025
025e563
Merge branch 'dev' into fix-edge-scrolling
rstanuwijaya May 22, 2025
5b44b34
Merge branch 'dev' into fix-edge-scrolling
mr-cheffy May 22, 2025
95abc99
Merge branch 'dev' into fix-edge-scrolling
mr-cheffy May 22, 2025
ead77dc
fix: Allow content window zoom
rstanuwijaya May 22, 2025
3c42ae3
Merge branch 'dev' into fix-edge-scrolling
mr-cheffy May 22, 2025
33162bd
test: Add tests for ZenEdgeScroll
rstanuwijaya May 23, 2025
83cd980
fix: Renamed var to gZenEdgeScrollManager and make _initialized as p…
rstanuwijaya May 23, 2025
976c206
Merge remote-tracking branch 'origin/fix-edge-scrolling' into fix-edg…
rstanuwijaya May 23, 2025
e63ca21
Discard changes to src/browser/components/preferences/zen-settings.js
mr-cheffy May 23, 2025
00145da
fix: Move edgescroll style to css
rstanuwijaya May 24, 2025
426b1d7
fix: Move trigger to zen-appcontent-wrapper
rstanuwijaya May 24, 2025
ea33664
fix: Removed _initialized
rstanuwijaya May 24, 2025
f6448d0
style: Formatting
rstanuwijaya May 24, 2025
83056ac
feat: Add observer for preference update
rstanuwijaya May 24, 2025
564f7e3
fix: Rename id to specify vertical trigger
rstanuwijaya May 25, 2025
460b979
fix: Modified logic for synthetic event
rstanuwijaya May 25, 2025
bc9cbab
fix: Specify edge scroll direction
rstanuwijaya May 25, 2025
b34da26
fix: Discard unused attribute
rstanuwijaya May 25, 2025
a7ac8a8
feat: Add horizontal trigger
rstanuwijaya May 25, 2025
0816774
fix: Change css position to absolute + make vertical on top
rstanuwijaya May 25, 2025
8ea7e05
fix: Correct Y offset
rstanuwijaya May 25, 2025
ee58617
Merge remote-tracking branch 'upstream/dev' into fix-edge-scrolling
rstanuwijaya May 25, 2025
f15fae0
Merge branch dev into fix-edge-scrolling
rstanuwijaya Jul 9, 2025
12c39bf
fix: move edgescroll.inc
rstanuwijaya Jul 18, 2025
0046eab
Merge branch 'dev' into fix-edge-scrolling
rstanuwijaya Jul 18, 2025
1252fe9
Update scrollwheel sendWheelEvent
rstanuwijaya Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .formal-git/components
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ scripts
workflows
winsign
flatpak
configs
configs
edgescroll
2 changes: 2 additions & 0 deletions src/browser/app/profile/features.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ pref('zen.glance.hold-duration', 300); // in ms
pref('zen.glance.open-essential-external-links', true);
pref('zen.glance.activation-method', 'alt'); // ctrl, alt, shift, none, hold

pref('zen.edgescroll.enabled', true);

pref('zen.view.sidebar-height-throttle', 200); // in ms
pref('zen.view.sidebar-expanded.max-width', 500);

Expand Down
1 change: 1 addition & 0 deletions src/browser/base/content/zen-assets.inc.xhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,5 @@ Services.scriptloader.loadSubScript("chrome://browser/content/zen-components/Zen
Services.scriptloader.loadSubScript("chrome://browser/content/zen-components/ZenGlanceManager.mjs", this);
Services.scriptloader.loadSubScript("chrome://browser/content/zen-components/ZenMediaController.mjs", this);
Services.scriptloader.loadSubScript("chrome://browser/content/zen-components/ZenDownloadAnimation.mjs", this);
Services.scriptloader.loadSubScript("chrome://browser/content/zen-components/ZenEdgeScrollManager.mjs", this);
</script>
4 changes: 4 additions & 0 deletions src/browser/base/content/zen-assets.jar.inc.mn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@
content/browser/zen-components/actors/ZenGlanceChild.sys.mjs (../../zen/glance/actors/ZenGlanceChild.sys.mjs)
content/browser/zen-components/actors/ZenGlanceParent.sys.mjs (../../zen/glance/actors/ZenGlanceParent.sys.mjs)

content/browser/zen-components/ZenEdgeScrollManager.mjs (../../zen/edgescroll/ZenEdgeScrollManager.mjs)
content/browser/zen-components/actors/ZenEdgeScrollChild.sys.mjs (../../zen/edgescroll/actors/ZenEdgeScrollChild.sys.mjs)
content/browser/zen-components/actors/ZenEdgeScrollParent.sys.mjs (../../zen/edgescroll/actors/ZenEdgeScrollParent.sys.mjs)

content/browser/zen-components/ZenFolders.mjs (../../zen/folders/ZenFolders.mjs)
content/browser/zen-styles/zen-folders.css (../../zen/folders/zen-folders.css)

Expand Down
7 changes: 7 additions & 0 deletions src/browser/components/preferences/zen-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,7 @@ var gZenWorkspacesSettings = {
};
Services.prefs.addObserver('zen.tab-unloader.enabled', tabsUnloaderPrefListener);
Services.prefs.addObserver('zen.glance.enabled', tabsUnloaderPrefListener); // We can use the same listener for both prefs
Services.prefs.addObserver('zen.edgescroll.enabled', tabsUnloaderPrefListener);
Services.prefs.addObserver(
'zen.workspaces.container-specific-essentials-enabled',
tabsUnloaderPrefListener
Expand All @@ -785,6 +786,7 @@ var gZenWorkspacesSettings = {
window.addEventListener('unload', () => {
Services.prefs.removeObserver('zen.tab-unloader.enabled', tabsUnloaderPrefListener);
Services.prefs.removeObserver('zen.glance.enabled', tabsUnloaderPrefListener);
Services.prefs.removeObserver('zen.edgescroll.enabled', tabsUnloaderPrefListener);
Services.prefs.removeObserver('zen.glance.activation-method', tabsUnloaderPrefListener);
Services.prefs.removeObserver(
'zen.workspaces.container-specific-essentials-enabled',
Expand Down Expand Up @@ -1169,6 +1171,11 @@ Preferences.addAll([
type: 'bool',
default: true,
},
{
id: 'zen.edgescroll.enabled',
type: 'bool',
default: true,
},
{
id: 'zen.theme.color-prefs.use-workspace-colors',
type: 'bool',
Expand Down
Loading