Skip to content

Conversation

ErdemGKSL
Copy link
Contributor

@ErdemGKSL ErdemGKSL commented May 29, 2025

I basically added a customization for styling the number of essentials per row.

Note: Tested for collapsed toolbar too, it doesn't get broken but also doesn't work when collapsed toolbar. It works fine, i will add image of it.

Localization added (l10n/en-US/browser/browser/preferences/zen-preferences.ftl): zen-browser/l10n-packs#161

Images:
image
image
image

@ErdemGKSL ErdemGKSL requested a review from mr-cheffy May 29, 2025 23:10
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Feature labels May 29, 2025
@ErdemGKSL ErdemGKSL changed the title feature/essential-tabs-per-row feat: Customizable essentials tab amount per row May 29, 2025
@blakegearin
Copy link

Wanted to note I'm going to pull this down and make sure it plays nicely with #8441

@mr-cheffy
Copy link
Member

Thank you for your contribution and the time you took to submit this PR regarding configurable essential tabs per row.

That said, we’ve decided not to merge this change at this time.

Our layout system is deliberately structured and tightly tuned to ensure a consistent and optimal user experience across a wide range of screen sizes and use cases. Introducing configurability in this area could introduce edge cases and break the visual balance we’ve worked hard to achieve.

We also want to note that for users or developers who need more customization, the system is already mod-friendly, and adjustments like this can be implemented externally through mods without affecting the core layout logic.

Again, thank you for your contribution and understanding. We welcome further suggestions and PRs, especially those aligned with the design direction and maintainability of the core project.

@mr-cheffy mr-cheffy closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants