Fix: New Tab Menu Not Displayed During Fullscreen Video Playback #9838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
mr-cheffy
requested changes
Aug 11, 2025
This reverts commit d0b3393.
…reen-video-playback
I tweaked the css that hides the sidebar when the browser is in fullscreen mode. Let me know if you think this is the correct approach. Screencast.From.2025-08-11.15-39-43.webm |
|
The URL Bar placement looks a bit weird when the Behavior setting is 'Normal' instead of 'Floating only when typing' or 'Always floating', as it slightly clips the top border. Should we always center it when in fullscreen mode or try to fix its position? 
|
…reen-video-playback
…reen-video-playback
mr-cheffy
requested changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5229 by exiting fullscreen mode when opening the new tab menu.