-
Notifications
You must be signed in to change notification settings - Fork 452
feat: implement new webform experience for generative AI #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new webform experience for generative AI #686
Conversation
3d429e1 to
3cb3ee3
Compare
3cb3ee3 to
aabb111
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
3a41434 to
4a8119f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when we are removing wip. Thanks!
|
ℹ️ Designs have changed, we've decided to remove some confirmation dialogs, this simplified the logic. Asking for re-review, changes are limited to this commit |
603817a to
371cffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when we are removing wip. Thank you!
bc17f55 to
bbd9e7a
Compare
@olivia-tsao We've decided to complete the work on translations, I've removed the wip tag and added the screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested different scenarios and left evidences in JIRA.
Found one bug:
- The sources (list of articles) links are not including the auth_token nor the is_gr_tracking query param. This means that we won't be able to track that the articles were opened, as we do on email experience
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.spec.tsx
Outdated
Show resolved
Hide resolved
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.spec.tsx
Outdated
Show resolved
Hide resolved
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.spec.tsx
Outdated
Show resolved
Hide resolved
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.spec.tsx
Outdated
Show resolved
Hide resolved
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.spec.tsx
Outdated
Show resolved
Hide resolved
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.spec.tsx
Outdated
Show resolved
Hide resolved
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.spec.tsx
Outdated
Show resolved
Hide resolved
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.spec.tsx
Outdated
Show resolved
Hide resolved
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.spec.tsx
Outdated
Show resolved
Hide resolved
src/modules/new-request-form/answer-bot-generative-modal/GenerativeAnswerBotModal.tsx
Outdated
Show resolved
Hide resolved
3b0729b to
bcd4903
Compare
68306bc to
e092ff2
Compare
e092ff2 to
c858873
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
🎉 This PR is included in version 4.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
There's a new webform experience from answerbot. We already had the autoreply with articles feature that would pop-up a dialog with articles that could solve the users request (check image below), and now with the new experience we have a AI generated answer. This PR introduces this feature.
This feature was already implemented on the HC repository:
https://github.com/zendesk/help_center/pull/32335
https://github.com/zendesk/help_center/pull/32463 (adds the feedback buttons)
ℹ️ A few notes:
@zendeskgarden/svg-iconspackage because I needed the icon@zendeskgarden/svg-icons/src/12/sparkle-fill.svgScreenshots
🎥 🍿 Demo
copehagen_demo.mov
LTR support
https://github.com/user-attachments/assets/810f8efa-3b24-4f6d-9c35-e16fce8eb797
Mobile support
https://github.com/user-attachments/assets/359d4834-76a9-41d1-be59-319fda1e1c95
Different browsers
Firefox
https://github.com/user-attachments/assets/9b54f4cc-c58d-4a8b-975c-64cc61ab97bf
Safari
https://github.com/user-attachments/assets/5ecd29e3-9d71-4978-9070-1962965cc577
Edge
https://github.com/user-attachments/assets/3e9e0ded-516c-4fc9-bc47-c842cba7cab3
Play-around
3 For Description use: How do I customize my help center?
Check RTL
Accessibility tests (used Zendesk A11y Tools)
Checklist