fix: pass ticket_brand_id in LURF autocomplete request#759
Merged
zendesk-navkumar merged 1 commit intomasterfrom Feb 26, 2026
Merged
fix: pass ticket_brand_id in LURF autocomplete request#759zendesk-navkumar merged 1 commit intomasterfrom
zendesk-navkumar merged 1 commit intomasterfrom
Conversation
zendesk-navkumar
force-pushed
the
navkumar/CRYSTAL-888-brand-lurf-filter
branch
from
45b3330 to
19236b4
Compare
ankur-tripathi-1909
previously approved these changes
Feb 26, 2026
When a lookup relationship field has a brand filter condition
(ticket_brand_id), the autocomplete API request now includes the
brand ID from the current Help Center brand. Previously the filter
was sent with an empty value because brandId was not wired through
to the LookupField component.
- Add brandId prop to LookupField
- Pass brandId from RequestFormField to LookupField
- Add startsWith("ticket_fields_") guard to skip non-field filters
- Add ticket_brand_id to search params when brand filter is defined
- Add tests for ticket_brand_id filter handling
CRYSTAL-888
zendesk-navkumar
force-pushed
the
navkumar/CRYSTAL-888-brand-lurf-filter
branch
from
19236b4 to
5cfaecc
Compare
BrunoBFerreira
approved these changes
Feb 26, 2026
Collaborator
|
🎉 This PR is included in version 4.30.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a lookup relationship field (LURF) has a brand-scoped filter condition (
ticket_brand_id), the autocomplete API request was sending the filter parameter with an empty value. This is becausebrandIdwas available as a prop inNewRequestFormbut was not passed through toLookupField, and the filter loop was not distinguishing betweenticket_fields_*andticket_brand_idfilter types.This fix:
brandIdas an optional prop toLookupFieldbrandIdfromRequestFormFieldtoLookupFieldticket_brand_idby checking if the filter includes a brand condition and thebrandIdis available, then setsfilter[dynamic_values][ticket_brand_id]with the actual brand IDbrandIdto theuseCallbackdependency arrayScreenshots
N/A — API-level change, no UI changes.
References
Checklist