This repository was archived by the owner on Nov 23, 2024. It is now read-only.
Open
Conversation
… the exit code of the executed helm command to make this plugin compatable with skaffold
This was referenced Oct 25, 2018
Author
|
Any update on this? I would like to get this pushed through so I can start working with the skaffold community |
|
+1 for getting this merged as I would like to use this when the corresponding PR for Skaffold gets merged. |
|
Now that GoogleContainerTools/skaffold#1617 has been merged, it would be great to get this PR merged so we don't have use a different fork. |
Contributor
|
Can you check the latest master? All fixes should be in place now. If it works then this is duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated available commands in helm-secrets and have program exit with the exit code of the executed helm command to make this plugin compatable with skaffold
This PR will make helm secrets compatible with skaffold by allow the dep, get, and delete commands to be used with helm secrets. These commands are used by skaffold and although I've tried to see if their code could be modified to selectively use helm secrets on certain commands it was easier to go this route.
I also pass through the exit code of the helm command since thats used by skaffold as well.