refactor(schema): add database filtering to JSON detection#2133
Open
CoreyWinkelmannPP wants to merge 1 commit intozendesk:masterfrom
Open
refactor(schema): add database filtering to JSON detection#2133CoreyWinkelmannPP wants to merge 1 commit intozendesk:masterfrom
CoreyWinkelmannPP wants to merge 1 commit intozendesk:masterfrom
Conversation
Collaborator
|
again, too much whitespace churn. does this really have a noticable impact on the database in a production system or is this kinda a theoretical win? |
Contributor
Author
|
Sorry, I will stop my neovim from updating the whitespace on PRs. This affects our systems and we do need it. If we don't focus our queries to the information schema we do experience issues. |
CoreyWinkelmannPP
force-pushed
the
information_schema_scoped
branch
from
004f828 to
449e203
Compare
|
Hi @osheroff - My team and I are looking to help revive this pull request, which was originally submitted by my colleague @CoreyWinkelmannPP. We have cleaned up the whitespace changes. Do you have any additional input or feedback on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
detectMariaDBJSONto acceptdbNameas a parameter, enabling filtering byCONSTRAINT_SCHEMAfor more precise JSON constraint detection within specified databases.The INFORMATION_SCHEMA tables, especially in production, can be a bottleneck if queried without constraints due to the high volume of metadata. By narrowing down the scope of JSON validation queries, we reduce potential load on INFORMATION_SCHEMA, improving efficiency and response times. This targeted approach allows for more precise schema capture while avoiding the pitfalls of exhaustive queries, especially in systems with many databases or tables.