make RabbitmqProducer using TopicInterpolator generate rounting key#2187
Open
eshizhan wants to merge 3 commits intozendesk:masterfrom
Open
make RabbitmqProducer using TopicInterpolator generate rounting key#2187eshizhan wants to merge 3 commits intozendesk:masterfrom
eshizhan wants to merge 3 commits intozendesk:masterfrom
Conversation
Collaborator
|
cool, but if I merge this I break all the installations that are currently using the |
Author
|
@osheroff added backward compatibility. |
Collaborator
|
ok great. can you add a test around the behavior then I'll merge? Sorry our producers are way undertested |
Author
Author
|
@osheroff Added metrics and error logging for RabbitmqProducer in this PR. The TODO commented code about ignoreProducerError will change the previous default behavior. I think it is up to you to decide how to handle it. Thanks for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This commit make RabbitmqProducer using TopicInterpolator. It is designed to use a unified logic, and additionally supports
typesubstitution as a routing key.P.S. also add metrics and error logging for RabbitmqProducer