Upgrade amazon-kinesis-producer dependency version to 1.0.4#2218
Open
RubenCordeiro wants to merge 1 commit intozendesk:masterfrom
Open
Upgrade amazon-kinesis-producer dependency version to 1.0.4#2218RubenCordeiro wants to merge 1 commit intozendesk:masterfrom
RubenCordeiro wants to merge 1 commit intozendesk:masterfrom
Conversation
- Upgrade amazon-kinesis-producer dependency version to 1.0.4. - Upgrade protobuf-java dependency version to 4.29.0.
Collaborator
|
have you tested this anywhere? iirc the test coverage for kinesis (really, a lot of producers) is relatively low. |
Author
We're going to do some internal testing on my end in one dev environment. Maybe this is a cue to add localstack for integration testing of the kinesis producer (and other producers for cloud native services). Will get back to you with results. |
|
Hi @RubenCordeiro , do you have any update? I think the upgrade of AWS SDK from v1 to v2 is also required, as mentioned here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #2217