Standard: Fix remaining offenses

Author: bquorning

.standard_todo.yml

@@ -4,7 +4,7 @@ module MigrationExtension
 
     def group(arg = nil)
       unless MigrationTools::MIGRATION_GROUPS.member?(arg.to_s)
-        raise "Invalid group \"#{arg.to_s}\" - valid groups are #{MigrationTools::MIGRATION_GROUPS.inspect}"
+        raise "Invalid group \"#{arg}\" - valid groups are #{MigrationTools::MIGRATION_GROUPS.inspect}"
       end
 
       self.migration_group = arg.to_s
@@ -30,4 +30,4 @@ def migration_group
     self.class.migration_group
   end
 end
-ActiveRecord::MigrationProxy.delegate :migration_group, :to => :migration
+ActiveRecord::MigrationProxy.delegate :migration_group, to: :migration

lib/migration_tools/migration_extension.rb

@@ -64,7 +64,7 @@ def define_migrate_list
       namespace :db do
         namespace :migrate do
           desc "Lists pending migrations"
-          task :list => :environment do
+          task list: :environment do
             if pending_migrations.empty?
               notify "Your database schema is up to date", group
             else
@@ -82,7 +82,7 @@ def define_migrate_group
       namespace :db do
         namespace :migrate do
           desc "Runs pending migrations for a given group"
-          task :group => :environment do
+          task group: :environment do
             if group.empty?
               notify "Please specify a migration group"
             elsif pending_migrations.empty?
@@ -112,7 +112,7 @@ def define_convenience_tasks
           [:list, :group].each do |ns|
             namespace ns do
               MigrationTools::MIGRATION_GROUPS.each do |migration_group|
-                desc "#{ns == :list ? 'Lists' : 'Executes'} the migrations for group #{migration_group}"
+                desc "#{(ns == :list) ? "Lists" : "Executes"} the migrations for group #{migration_group}"
                 task migration_group => :environment do
                   self.group = migration_group.to_s
                   Rake::Task["db:migrate:#{ns}"].invoke

lib/migration_tools/tasks.rb

@@ -11,6 +11,6 @@
 
 dir = File.expand_path("../migrations", __FILE__)
 ActiveRecord::Migrator.migrations_paths.replace([dir])
-Dir.glob(File.join(dir, "*.rb")).each { |f| require f }
+Dir.glob(File.join(dir, "*.rb")).sort.each { |f| require f }
 
 ActiveRecord::Migration.verbose = false

test/helper.rb

@@ -5,8 +5,8 @@
     ENV["GROUP"] = nil
 
     ActiveRecord::Base.establish_connection(
-      :adapter => "sqlite3",
-      :database => ":memory:"
+      adapter: "sqlite3",
+      database: ":memory:"
     )
 
     Rake::Task.clear
@@ -40,12 +40,10 @@ def migration_proxy(m)
   end
 
   it "runtime_checking" do
-    begin
-      eval("class Kappa < MIGRATION_CLASS; group 'drunk'; end")
-      fail "You should not be able to specify custom groups"
-    rescue RuntimeError => e
-      assert e.message.index('Invalid group "drunk" - valid groups are ["before", "during", "after", "change"]')
-    end
+    eval("class Kappa < MIGRATION_CLASS; group 'drunk'; end", binding, __FILE__, __LINE__)
+    fail "You should not be able to specify custom groups"
+  rescue RuntimeError => e
+    assert e.message.index('Invalid group "drunk" - valid groups are ["before", "during", "after", "change"]')
   end
 
   it "migration_proxy_delegation" do