Implement signed AuthnRequests #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnthethird
force-pushed
the
signed_authnrequest
branch
from
80ebeb1 to
4e450c7
Compare
There was a problem hiding this comment.
I don't think you need to dup the params
There was a problem hiding this comment.
params is mutated a few lines down
|
Thanks! |
|
what's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements signing of SAML requests, using the much simpler process of signing the URL instead of embedded signatures in the XML.
This patch has been tested with Microsoft ADFS, which can be set to require signed requests via the PowerShell