drop support for Ruby 2.7 and 3.0, update CI #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razumau
force-pushed
the
jury.razumau/modernise_workflows
branch
4 times, most recently
from
3be57b9 to
9a9b00d
Compare
razumau
changed the title
codealchemy
approved these changes
Aug 12, 2025
bquorning
reviewed
Aug 13, 2025
| s.files = Dir.glob('{lib,util}/**/*') << 'LICENSE' | ||
|
|
||
| s.required_ruby_version = ">= 2.7" | ||
| s.required_ruby_version = ">= 3.1" |
Member
There was a problem hiding this comment.
Do we know (do we have a way of knowing) which version our users are using?
Contributor
Author
There was a problem hiding this comment.
Theoretically, RubyGems.org’s download logs would have Ruby versions.
Realistically, customers can complain to our support and convince us to continue supporting older versions. So I think we should just scream-test this.
Uses correct main branch, updates checkout and setup-ruby actions, runs spec-live on Ruby 3.4, adds JRuby 10, removes unnecessary `bundle install`.
razumau
force-pushed
the
jury.razumau/modernise_workflows
branch
from
9a9b00d to
911e887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for EOL versions of Ruby (even 3.1 is actually EOL at this time, but we’ll leave it for now).
Checks in
Gemfile.lock(I spent some time figuring out why some tests failed on Ruby 2.7 but not 3.4, and that was because different versions of faraday got installed for 2.7 and 3.4).Updates rubocop and applies a bunch of cops.
In CI workflow: uses correct main branch, updates checkout and setup-ruby actions, runs spec-live on Ruby 3.4, adds JRuby 10, removes unnecessary
bundle install.To do in follow-up PRs: remove limits on rspec gems, simplify
Gemfile.